[Workflow] Made the configuration more robust for the 'property' key

Author: lyrixx

DependencyInjection/Configuration.php

@@ -303,7 +303,7 @@ private function addWorkflowSection(ArrayNodeDefinition $rootNode)
                                                 ->end()
                                             ->end()
                                             ->scalarNode('property')
-                                                ->defaultValue('marking')
+                                                ->defaultNull() // In Symfony 5.0, set "marking" as default property
                                             ->end()
                                             ->scalarNode('service')
                                                 ->cannotBeEmpty()
@@ -481,6 +481,14 @@ private function addWorkflowSection(ArrayNodeDefinition $rootNode)
                                         return $v;
                                     })
                                 ->end()
+                                ->validate()
+                                    ->ifTrue(function ($v) {
+                                        return isset($v['marking_store']['property'])
+                                            && (!isset($v['marking_store']['type']) || 'method' !== $v['marking_store']['type'])
+                                        ;
+                                    })
+                                    ->thenInvalid('"property" option is only supported by the "method" marking store.')
+                                ->end()
                             ->end()
                         ->end()
                     ->end()

DependencyInjection/FrameworkExtension.php

@@ -666,7 +666,7 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $
                 if ('method' === $workflow['marking_store']['type']) {
                     $markingStoreDefinition->setArguments([
                         'state_machine' === $type, //single state
-                        $workflow['marking_store']['property'],
+                        $workflow['marking_store']['property'] ?? 'marking',
                     ]);
                 } else {
                     foreach ($workflow['marking_store']['arguments'] as $argument) {