Merge branch '3.2'

* 3.2:
  [Config] removed obsolete code
  [Form] Improve rounding precision
  [Routing] Ignore hidden directories when loading routes from annotations
  fixed CS

Author: fabpot

Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php

@@ -242,7 +242,8 @@ private function round($number)
         if (null !== $this->scale && null !== $this->roundingMode) {
             // shift number to maintain the correct scale during rounding
             $roundingCoef = pow(10, $this->scale);
-            $number *= $roundingCoef;
+            // string representation to avoid rounding errors, similar to bcmul()
+            $number = (string) ($number * $roundingCoef);
 
             switch ($this->roundingMode) {
                 case self::ROUND_CEILING:

Extension/Validator/Util/ServerParams.php

@@ -11,9 +11,11 @@
 
 namespace Symfony\Component\Form\Extension\Validator\Util;
 
+use Symfony\Component\Form\Util\ServerParams as BaseServerParams;
+
 /**
  * @author Bernhard Schussek <bschussek@gmail.com>
  */
-class ServerParams extends \Symfony\Component\Form\Util\ServerParams
+class ServerParams extends BaseServerParams
 {
 }

Tests/AbstractLayoutTest.php

@@ -14,8 +14,9 @@
 use Symfony\Component\Form\FormError;
 use Symfony\Component\Form\FormView;
 use Symfony\Component\Form\Extension\Csrf\CsrfExtension;
+use Symfony\Component\Form\Test\FormIntegrationTestCase;
 
-abstract class AbstractLayoutTest extends \Symfony\Component\Form\Test\FormIntegrationTestCase
+abstract class AbstractLayoutTest extends FormIntegrationTestCase
 {
     protected $csrfTokenManager;
     protected $testableFeatures = array();

Tests/CompoundFormPerformanceTest.php

@@ -11,10 +11,12 @@
 
 namespace Symfony\Component\Form\Tests;
 
+use Symfony\Component\Form\Test\FormPerformanceTestCase;
+
 /**
  * @author Bernhard Schussek <bschussek@gmail.com>
  */
-class CompoundFormPerformanceTest extends \Symfony\Component\Form\Test\FormPerformanceTestCase
+class CompoundFormPerformanceTest extends FormPerformanceTestCase
 {
     /**
      * Create a compound form multiple times, as happens in a collection form.

Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php

@@ -305,6 +305,8 @@ public function reverseTransformWithRoundingProvider()
             array(1, '123,44', 123.4, NumberToLocalizedStringTransformer::ROUND_DOWN),
             array(1, '-123,45', -123.4, NumberToLocalizedStringTransformer::ROUND_DOWN),
             array(1, '-123,44', -123.4, NumberToLocalizedStringTransformer::ROUND_DOWN),
+            array(2, '37.37', 37.37, NumberToLocalizedStringTransformer::ROUND_DOWN),
+            array(2, '2.01', 2.01, NumberToLocalizedStringTransformer::ROUND_DOWN),
             // round halves (.5) to the next even number
             array(0, '1234,6', 1235, NumberToLocalizedStringTransformer::ROUND_HALF_EVEN),
             array(0, '1234,5', 1234, NumberToLocalizedStringTransformer::ROUND_HALF_EVEN),

Tests/Extension/Core/Type/BaseTypeTest.php

@@ -11,10 +11,12 @@
 
 namespace Symfony\Component\Form\Tests\Extension\Core\Type;
 
+use Symfony\Component\Form\Test\TypeTestCase;
+
 /**
  * @author Bernhard Schussek <bschussek@gmail.com>
  */
-abstract class BaseTypeTest extends \Symfony\Component\Form\Test\TypeTestCase
+abstract class BaseTypeTest extends TypeTestCase
 {
     public function testPassDisabledAsOption()
     {

Tests/Extension/Core/Type/CheckboxTypeTest.php

@@ -12,8 +12,9 @@
 namespace Symfony\Component\Form\Tests\Extension\Core\Type;
 
 use Symfony\Component\Form\CallbackTransformer;
+use Symfony\Component\Form\Test\TypeTestCase;
 
-class CheckboxTypeTest extends \Symfony\Component\Form\Test\TypeTestCase
+class CheckboxTypeTest extends TypeTestCase
 {
     public function testDataIsFalseByDefault()
     {

Tests/Extension/Core/Type/CollectionTypeTest.php

@@ -11,9 +11,10 @@
 
 namespace Symfony\Component\Form\Tests\Extension\Core\Type;
 
+use Symfony\Component\Form\Test\TypeTestCase;
 use Symfony\Component\Form\Tests\Fixtures\Author;
 
-class CollectionTypeTest extends \Symfony\Component\Form\Test\TypeTestCase
+class CollectionTypeTest extends TypeTestCase
 {
     public function testContainsNoChildByDefault()
     {

Tests/Extension/Core/Type/FileTypeTest.php

@@ -11,7 +11,9 @@
 
 namespace Symfony\Component\Form\Tests\Extension\Core\Type;
 
-class FileTypeTest extends \Symfony\Component\Form\Test\TypeTestCase
+use Symfony\Component\Form\Test\TypeTestCase;
+
+class FileTypeTest extends TypeTestCase
 {
     // https://github.com/symfony/symfony/pull/5028
     public function testSetData()

Tests/Extension/Core/Type/PasswordTypeTest.php

@@ -11,7 +11,9 @@
 
 namespace Symfony\Component\Form\Tests\Extension\Core\Type;
 
-class PasswordTypeTest extends \Symfony\Component\Form\Test\TypeTestCase
+use Symfony\Component\Form\Test\TypeTestCase;
+
+class PasswordTypeTest extends TypeTestCase
 {
     public function testEmptyIfNotSubmitted()
     {