minor #44825 [Filesystem] Renamed reused variable $files in Filesystem::doRemove() (fwolfsjaeger)

This PR was merged into the 6.1 branch.

Discussion
----------

[Filesystem] Renamed reused variable `$files` in `Filesystem::doRemove()`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

It's not really a bug, but the variable name $files is already used for the foreach loop.

Commits
-------

6d3f3d74ef [Filesystem] Renamed reused variable `$files` in `Filesystem::doRemove()`

Author: fabpot

Filesystem.php

@@ -178,8 +178,8 @@ private static function doRemove(array $files, bool $isRecursive): void
                     }
                 }
 
-                $files = new \FilesystemIterator($file, \FilesystemIterator::CURRENT_AS_PATHNAME | \FilesystemIterator::SKIP_DOTS);
-                self::doRemove(iterator_to_array($files, true), true);
+                $filesystemIterator = new \FilesystemIterator($file, \FilesystemIterator::CURRENT_AS_PATHNAME | \FilesystemIterator::SKIP_DOTS);
+                self::doRemove(iterator_to_array($filesystemIterator, true), true);
 
                 if (!self::box('rmdir', $file) && file_exists($file) && !$isRecursive) {
                     $lastError = self::$lastError;