Add return types to internal & magic methods when possible

Author: nicolas-grekas

Argument/RewindableGenerator.php

@@ -28,14 +28,14 @@ public function __construct(callable $generator, $count)
         $this->count = $count;
     }
 
-    public function getIterator()
+    public function getIterator(): \Traversable
     {
         $g = $this->generator;
 
         return $g();
     }
 
-    public function count()
+    public function count(): int
     {
         if (\is_callable($count = $this->count)) {
             $this->count = $count();

Tests/Fixtures/includes/ProjectExtension.php

@@ -25,17 +25,17 @@ public function load(array $configs, ContainerBuilder $configuration)
         return $configuration;
     }
 
-    public function getXsdValidationBasePath()
+    public function getXsdValidationBasePath(): string
     {
         return false;
     }
 
-    public function getNamespace()
+    public function getNamespace(): string
     {
         return 'http://www.example.com/schema/project';
     }
 
-    public function getAlias()
+    public function getAlias(): string
     {
         return 'project';
     }

Tests/Fixtures/includes/ProjectWithXsdExtension.php

@@ -2,17 +2,17 @@
 
 class ProjectWithXsdExtension extends ProjectExtension
 {
-    public function getXsdValidationBasePath()
+    public function getXsdValidationBasePath(): string
     {
         return __DIR__.'/schema';
     }
 
-    public function getNamespace()
+    public function getNamespace(): string
     {
         return 'http://www.example.com/schema/projectwithxsd';
     }
 
-    public function getAlias()
+    public function getAlias(): string
     {
         return 'projectwithxsd';
     }

Tests/Fixtures/includes/ProjectWithXsdExtensionInPhar.phar

@@ -83,17 +83,17 @@ public function callPassed()
 
 class DummyProxyDumper implements ProxyDumper
 {
-    public function isProxyCandidate(Definition $definition)
+    public function isProxyCandidate(Definition $definition): bool
     {
         return $definition->isLazy();
     }
 
-    public function getProxyFactoryCode(Definition $definition, $id, $factoryCall = null)
+    public function getProxyFactoryCode(Definition $definition, $id, $factoryCall = null): string
     {
         return "        // lazy factory for {$definition->getClass()}\n\n";
     }
 
-    public function getProxyCode(Definition $definition)
+    public function getProxyCode(Definition $definition): string
     {
         return "// proxy code for {$definition->getClass()}\n";
     }

Tests/Fixtures/includes/classes.php

@@ -11,17 +11,17 @@
 
 class ProjectWithXsdExtensionInPhar extends ProjectExtension
 {
-    public function getXsdValidationBasePath()
+    public function getXsdValidationBasePath(): string
     {
         return __DIR__.'/schema';
     }
 
-    public function getNamespace()
+    public function getNamespace(): string
     {
         return 'http://www.example.com/schema/projectwithxsdinphar';
     }
 
-    public function getAlias()
+    public function getAlias(): string
     {
         return 'projectwithxsdinphar';
     }