feature #21263 [DI] Mark generated containers as final (nicolas-grekas)

fabpot · fabpot · commit e128eac8abad · 2017-01-15T07:59:50.000-08:00
This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI] Mark generated containers as final

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

So that we don't have to care anymore about BC for protected methods in generated containers.
Will leverage deprecations triggered in #20493

Commits
-------

ce0ee1e484 [DI] Mark generated containers as final
diff --git a/Dumper/PhpDumper.php b/Dumper/PhpDumper.php
@@ -805,6 +805,8 @@ private function startClass($class, $baseClass, $namespace)
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class $class extends $baseClass
 {
diff --git a/Tests/Fixtures/php/services1-1.php b/Tests/Fixtures/php/services1-1.php
@@ -14,6 +14,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class Container extends AbstractContainer
 {
diff --git a/Tests/Fixtures/php/services1.php b/Tests/Fixtures/php/services1.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services10.php b/Tests/Fixtures/php/services10.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services12.php b/Tests/Fixtures/php/services12.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services13.php b/Tests/Fixtures/php/services13.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services19.php b/Tests/Fixtures/php/services19.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services24.php b/Tests/Fixtures/php/services24.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services26.php b/Tests/Fixtures/php/services26.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services31.php b/Tests/Fixtures/php/services31.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services32.php b/Tests/Fixtures/php/services32.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services33.php b/Tests/Fixtures/php/services33.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services8.php b/Tests/Fixtures/php/services8.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services9.php b/Tests/Fixtures/php/services9.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {
diff --git a/Tests/Fixtures/php/services9_compiled.php b/Tests/Fixtures/php/services9_compiled.php
@@ -13,6 +13,8 @@
  *
  * This class has been auto-generated
  * by the Symfony Dependency Injection Component.
+ *
+ * @final since Symfony 3.3
  */
 class ProjectServiceContainer extends Container
 {

Original file line number	Diff line number	Diff line change
`@@ -805,6 +805,8 @@ private function startClass($class, $baseClass, $namespace)`
`805`	`805`	`*`
`806`	`806`	`* This class has been auto-generated`
`807`	`807`	`* by the Symfony Dependency Injection Component.`
	`808`	`+ *`
	`809`	`+ * @final since Symfony 3.3`
`808`	`810`	`*/`
`809`	`811`	`class $class extends $baseClass`
`810`	`812`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@`
`14`	`14`	`*`
`15`	`15`	`* This class has been auto-generated`
`16`	`16`	`* by the Symfony Dependency Injection Component.`
	`17`	`+ *`
	`18`	`+ * @final since Symfony 3.3`
`17`	`19`	`*/`
`18`	`20`	`class Container extends AbstractContainer`
`19`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@`
`13`	`13`	`*`
`14`	`14`	`* This class has been auto-generated`
`15`	`15`	`* by the Symfony Dependency Injection Component.`
	`16`	`+ *`
	`17`	`+ * @final since Symfony 3.3`
`16`	`18`	`*/`
`17`	`19`	`class ProjectServiceContainer extends Container`
`18`	`20`	`{`