minor #32969 Use assertContainsEquals when needed (jderusse)

nicolas-grekas · nicolas-grekas · commit a46a86db79e7 · 2019-08-06T08:52:18.000+02:00
This PR was merged into the 3.4 branch.

Discussion
----------

Use assertContainsEquals when needed

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32844
| License       | MIT
| Doc PR        | NA

This PR replaces deprecated paramèter `$checkForObjectIdentity` of methods `assertContains` by the dedicated method `assertContainsEquals`

Commits
-------

f842e59685 Use assert assertContainsEquals when needed
diff --git a/Tests/Compiler/MergeExtensionConfigurationPassTest.php b/Tests/Compiler/MergeExtensionConfigurationPassTest.php
@@ -85,7 +85,7 @@ public function testExtensionConfigurationIsTrackedByDefault()
         $pass = new MergeExtensionConfigurationPass();
         $pass->process($container);
 
-        $this->assertContains(new FileResource(__FILE__), $container->getResources(), '', false, false);
+        $this->assertContainsEquals(new FileResource(__FILE__), $container->getResources());
     }
 
     public function testOverriddenEnvsAreMerged()

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ public function testExtensionConfigurationIsTrackedByDefault()`
`85`	`85`	`$pass = new MergeExtensionConfigurationPass();`
`86`	`86`	`$pass->process($container);`
`87`	`87`
`88`		`- $this->assertContains(new FileResource(__FILE__), $container->getResources(), '', false, false);`
	`88`	`+ $this->assertContainsEquals(new FileResource(__FILE__), $container->getResources());`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`public function testOverriddenEnvsAreMerged()`