Add return types to tests and final|internal|private methods

Author: nicolas-grekas

Argument/BoundArgument.php

@@ -43,7 +43,7 @@ public function __construct($value, bool $trackUsage = true, int $type = 0, stri
     /**
      * {@inheritdoc}
      */
-    public function getValues()
+    public function getValues(): array
     {
         return [$this->value, $this->identifier, $this->used, $this->type, $this->file];
     }

Compiler/ServiceLocatorTagPass.php

@@ -89,10 +89,8 @@ protected function processValue($value, $isRoot = false)
     /**
      * @param Reference[] $refMap
      * @param string|null $callerId
-     *
-     * @return Reference
      */
-    public static function register(ContainerBuilder $container, array $refMap, $callerId = null)
+    public static function register(ContainerBuilder $container, array $refMap, $callerId = null): Reference
     {
         foreach ($refMap as $id => $ref) {
             if (!$ref instanceof Reference) {

Tests/Compiler/ExtensionCompilerPassTest.php

@@ -61,7 +61,7 @@ public function __construct($alias)
         $this->alias = $alias;
     }
 
-    public function getAlias()
+    public function getAlias(): string
     {
         return $this->alias;
     }

Tests/Compiler/IntegrationTest.php

@@ -406,7 +406,7 @@ public function testTaggedServiceLocatorWithDefaultIndex()
 
 class ServiceSubscriberStub implements ServiceSubscriberInterface
 {
-    public static function getSubscribedServices()
+    public static function getSubscribedServices(): array
     {
         return [];
     }

Tests/Compiler/MergeExtensionConfigurationPassTest.php

@@ -132,7 +132,7 @@ public function testThrowingExtensionsGetMergedBag()
 
 class FooConfiguration implements ConfigurationInterface
 {
-    public function getConfigTreeBuilder()
+    public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('foo');
         $treeBuilder->getRootNode()
@@ -147,12 +147,12 @@ public function getConfigTreeBuilder()
 
 class FooExtension extends Extension
 {
-    public function getAlias()
+    public function getAlias(): string
     {
         return 'foo';
     }
 
-    public function getConfiguration(array $config, ContainerBuilder $container)
+    public function getConfiguration(array $config, ContainerBuilder $container): ?ConfigurationInterface
     {
         return new FooConfiguration();
     }
@@ -179,12 +179,12 @@ public function load(array $configs, ContainerBuilder $container)
 
 class ThrowingExtension extends Extension
 {
-    public function getAlias()
+    public function getAlias(): string
     {
         return 'throwing';
     }
 
-    public function getConfiguration(array $config, ContainerBuilder $container)
+    public function getConfiguration(array $config, ContainerBuilder $container): ?ConfigurationInterface
     {
         return new FooConfiguration();
     }

Tests/Compiler/RegisterEnvVarProcessorsPassTest.php

@@ -78,15 +78,15 @@ public function getEnv($prefix, $name, \Closure $getEnv)
         return $getEnv($name);
     }
 
-    public static function getProvidedTypes()
+    public static function getProvidedTypes(): array
     {
         return ['foo' => 'string'];
     }
 }
 
 class BadProcessor extends SimpleProcessor
 {
-    public static function getProvidedTypes()
+    public static function getProvidedTypes(): array
     {
         return ['foo' => 'string|foo'];
     }

Tests/Compiler/ValidateEnvPlaceholdersPassTest.php

@@ -313,7 +313,7 @@ private function doProcess(ContainerBuilder $container): void
 
 class EnvConfiguration implements ConfigurationInterface
 {
-    public function getConfigTreeBuilder()
+    public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('env_extension');
         $treeBuilder->getRootNode()
@@ -376,15 +376,15 @@ public function getConfigTreeBuilder()
 
 class EnvConfigurationWithoutRootNode implements ConfigurationInterface
 {
-    public function getConfigTreeBuilder()
+    public function getConfigTreeBuilder(): TreeBuilder
     {
         return new TreeBuilder();
     }
 }
 
 class ConfigurationWithArrayNodeRequiringOneElement implements ConfigurationInterface
 {
-    public function getConfigTreeBuilder()
+    public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('env_extension');
         $treeBuilder->getRootNode()
@@ -410,12 +410,12 @@ public function __construct(ConfigurationInterface $configuration = null)
         $this->configuration = $configuration ?? new EnvConfiguration();
     }
 
-    public function getAlias()
+    public function getAlias(): string
     {
         return 'env_extension';
     }
 
-    public function getConfiguration(array $config, ContainerBuilder $container)
+    public function getConfiguration(array $config, ContainerBuilder $container): ?ConfigurationInterface
     {
         return $this->configuration;
     }

Tests/Dumper/PhpDumperTest.php

@@ -1328,7 +1328,7 @@ public function getEnv($prefix, $name, \Closure $getEnv)
         return str_rot13($getEnv($name));
     }
 
-    public static function getProvidedTypes()
+    public static function getProvidedTypes(): array
     {
         return ['rot13' => 'string'];
     }

Tests/Extension/ExtensionTest.php

@@ -50,7 +50,7 @@ public function load(array $configs, ContainerBuilder $container)
     {
     }
 
-    public function isConfigEnabled(ContainerBuilder $container, array $config)
+    public function isConfigEnabled(ContainerBuilder $container, array $config): bool
     {
         return parent::isConfigEnabled($container, $config);
     }

Tests/Fixtures/BarFactory.php

@@ -11,7 +11,7 @@ class BarFactory
 
     public function __construct(iterable $bars)
     {
-        $this->bars = \iterator_to_array($bars);
+        $this->bars = iterator_to_array($bars);
     }
 
     public function getDefaultBar(): BarInterface