minor #15172 [DependencyInjection] fixed FrozenParameterBag and improved Parameter… (Tomaz Ahlin)

This PR was squashed before being merged into the 2.3 branch (closes #15172).

Discussion
----------

[DependencyInjection] fixed FrozenParameterBag and improved Parameter…

The ParameterBagInterface was missing some @throws annotations, so the FrozenParameterBag class was a violation of Liskov subtitution principle. Also the ParameterBagInterface was missing the remove method.

(Optionally the ParameterBagInterface can be later split into two smaller interfaces, because the FrozenParameterBag shouldn't have the add, remove methods in the first place.)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

I have also fixed removing elements from FrozenParameterBag, as introduced by @satahippy
#8

Commits
-------

3ad0794 [DependencyInjection] fixed FrozenParameterBag and improved Parameter…

Author: fabpot

ParameterBag/ParameterBagInterface.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\DependencyInjection\ParameterBag;
 
+use Symfony\Component\DependencyInjection\Exception\LogicException;
 use Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException;
 
 /**
@@ -25,6 +26,8 @@ interface ParameterBagInterface
     /**
      * Clears all parameters.
      *
+     * @throws LogicException if the ParameterBagInterface can not be cleared
+     *
      * @api
      */
     public function clear();
@@ -34,6 +37,8 @@ public function clear();
      *
      * @param array $parameters An array of parameters
      *
+     * @throws LogicException if the parameter can not be added
+     *
      * @api
      */
     public function add(array $parameters);
@@ -66,6 +71,8 @@ public function get($name);
      * @param string $name  The parameter name
      * @param mixed  $value The parameter value
      *
+     * @throws LogicException if the parameter can not be set
+     *
      * @api
      */
     public function set($name, $value);

Tests/ParameterBag/FrozenParameterBagTest.php

@@ -57,4 +57,13 @@ public function testAdd()
         $bag = new FrozenParameterBag(array());
         $bag->add(array());
     }
+
+    /**
+     * @expectedException \LogicException
+     */
+    public function testRemove()
+    {
+        $bag = new FrozenParameterBag(array('foo' => 'bar'));
+        $bag->remove('foo');
+    }
 }