Use typed properties in tests as much as possible

nicolas-grekas · nicolas-grekas · commit 6b95f3cb29cd · 2023-07-25T10:53:33.000+02:00
diff --git a/Tests/Fixtures/DummyMessage.php b/Tests/Fixtures/DummyMessage.php
@@ -4,7 +4,7 @@
 
 class DummyMessage
 {
-    private $message;
+    private string $message;
 
     public function __construct(string $message)
     {
diff --git a/Tests/Transport/ConnectionTest.php b/Tests/Transport/ConnectionTest.php
@@ -808,10 +808,10 @@ private function createDelayOrRetryConnection(\AMQPExchange $delayExchange, stri
 
 class TestAmqpFactory extends AmqpFactory
 {
-    private $connection;
-    private $channel;
-    private $queue;
-    private $exchange;
+    private \AMQPConnection $connection;
+    private \AMQPChannel $channel;
+    private \AMQPQueue $queue;
+    private \AMQPExchange $exchange;
 
     public function __construct(\AMQPConnection $connection, \AMQPChannel $channel, \AMQPQueue $queue, \AMQPExchange $exchange)
     {

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`class DummyMessage`
`6`	`6`	`{`
`7`		`- private $message;`
	`7`	`+ private string $message;`
`8`	`8`
`9`	`9`	`public function __construct(string $message)`
`10`	`10`	`{`
Original file line number	Diff line number	Diff line change
`@@ -808,10 +808,10 @@ private function createDelayOrRetryConnection(\AMQPExchange $delayExchange, stri`
`808`	`808`
`809`	`809`	`class TestAmqpFactory extends AmqpFactory`
`810`	`810`	`{`
`811`		`- private $connection;`
`812`		`- private $channel;`
`813`		`- private $queue;`
`814`		`- private $exchange;`
	`811`	`+ private \AMQPConnection $connection;`
	`812`	`+ private \AMQPChannel $channel;`
	`813`	`+ private \AMQPQueue $queue;`
	`814`	`+ private \AMQPExchange $exchange;`
`815`	`815`
`816`	`816`	`public function __construct(\AMQPConnection $connection, \AMQPChannel $channel, \AMQPQueue $queue, \AMQPExchange $exchange)`
`817`	`817`	`{`