-
-
Notifications
You must be signed in to change notification settings - Fork 137
[Store][ChromaDb] Split store as dedicated package #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ee6b791 to
53d5e95
Compare
| @@ -0,0 +1,59 @@ | |||
| { | |||
| "name": "symfony/ai-chromadb-store", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabpot is the package name correct?
6c54a05 to
318e026
Compare
|
@OskarStark nice to split, but what about #1012 |
Similar to how tools were split in the Agent component, this extracts the ChromaDb store into its own standalone package with: - Independent composer.json with proper dependencies - Dedicated test suite with phpunit.xml.dist - Standard package files (LICENSE, README.md, CHANGELOG.md) - GitHub integration files for subtree split workflow
318e026 to
9792e95
Compare
|
Final review from @chr-hertel needed, otherwise we need to rebase afterwards 👍🏻 |
| if (!class_exists(Client::class)) { | ||
| throw new RuntimeException('For using the ChromaDB as retrieval vector store, the codewithkyrian/chromadb-php package is required. Try running "composer require codewithkyrian/chromadb-php".'); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah nice :)
chr-hertel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me sir
|
Will fix the deptrac stuff and would like to get the confirmation for the package name from @fabpot, then good to merge Edit: |
Similar to how tools were split in the Agent component, this extracts the ChromaDb store into its own standalone package.