Skip to content

Conversation

@OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Dec 5, 2025

Q A
Bug fix? no
New feature? yes
Docs? no
Issues --
License MIT

Similar to how tools were split in the Agent component, this extracts the ChromaDb store into its own standalone package.

@carsonbot carsonbot added Feature New feature Store Issues & PRs about the AI Store component Status: Needs Review labels Dec 5, 2025
@OskarStark OskarStark force-pushed the chromadb-store-bridge branch 3 times, most recently from ee6b791 to 53d5e95 Compare December 5, 2025 17:06
@OskarStark OskarStark changed the title [Store][ChromaDb] Split ChromaDb store as dedicated package [Store][ChromaDb] Split store as dedicated package Dec 5, 2025
@@ -0,0 +1,59 @@
{
"name": "symfony/ai-chromadb-store",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot is the package name correct?

@OskarStark OskarStark force-pushed the chromadb-store-bridge branch 2 times, most recently from 6c54a05 to 318e026 Compare December 5, 2025 17:14
@xprojects-de
Copy link

@OskarStark nice to split, but what about #1012
Is this merged before?

Similar to how tools were split in the Agent component, this extracts the ChromaDb store into its own standalone package with:
- Independent composer.json with proper dependencies
- Dedicated test suite with phpunit.xml.dist
- Standard package files (LICENSE, README.md, CHANGELOG.md)
- GitHub integration files for subtree split workflow
@OskarStark
Copy link
Contributor Author

Final review from @chr-hertel needed, otherwise we need to rebase afterwards 👍🏻

Comment on lines -31 to -33
if (!class_exists(Client::class)) {
throw new RuntimeException('For using the ChromaDB as retrieval vector store, the codewithkyrian/chromadb-php package is required. Try running "composer require codewithkyrian/chromadb-php".');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah nice :)

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me sir

@OskarStark
Copy link
Contributor Author

OskarStark commented Dec 6, 2025

Will fix the deptrac stuff and would like to get the confirmation for the package name from @fabpot, then good to merge

Edit:
Ah no the frameworkbundle config needs to check for the store class available to allow the options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature Status: Reviewed Store Issues & PRs about the AI Store component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants