Skip to content

Commit ddf1694

Browse files
Simplify Transport instantiation with nullable logger
Remove ternary operators now that mcp/sdk#152 allows null logger in Transport constructors.
1 parent a8500ca commit ddf1694

File tree

2 files changed

+7
-15
lines changed

2 files changed

+7
-15
lines changed

src/mcp-bundle/src/Command/McpCommand.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@ public function __construct(
3131

3232
protected function execute(InputInterface $input, OutputInterface $output): int
3333
{
34-
$transport = $this->logger
35-
? new StdioTransport(logger: $this->logger)
36-
: new StdioTransport();
34+
$transport = new StdioTransport(logger: $this->logger);
3735
$this->server->run($transport);
3836

3937
return Command::SUCCESS;

src/mcp-bundle/src/Controller/McpController.php

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,12 @@ public function __construct(
3535

3636
public function handle(Request $request): Response
3737
{
38-
$transport = $this->logger
39-
? new StreamableHttpTransport(
40-
$this->httpMessageFactory->createRequest($request),
41-
$this->responseFactory,
42-
$this->streamFactory,
43-
logger: $this->logger,
44-
)
45-
: new StreamableHttpTransport(
46-
$this->httpMessageFactory->createRequest($request),
47-
$this->responseFactory,
48-
$this->streamFactory,
49-
);
38+
$transport = new StreamableHttpTransport(
39+
$this->httpMessageFactory->createRequest($request),
40+
$this->responseFactory,
41+
$this->streamFactory,
42+
logger: $this->logger,
43+
);
5044

5145
return $this->httpFoundationFactory->createResponse(
5246
$this->server->run($transport),

0 commit comments

Comments
 (0)