Add -Xfrontend -enable-address-dependencies

Temporary option to bootstrap '@'_addressable enforcement.

Once all the SILGen cases are handled, we won't need this option.

Author: atrick

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/LifetimeDependenceInsertion.swift

@@ -218,7 +218,7 @@ private extension LifetimeDependentApply.LifetimeSourceInfo {
       bases.append(source.value)
     case .result, .inParameter, .inoutParameter:
       // addressable dependencies directly depend on the incoming address.
-      if source.convention.isAddressable {
+      if context.options.enableAddressDependencies() && source.convention.isAddressable {
         bases.append(source.value)
         return
       }

SwiftCompilerSources/Sources/Optimizer/PassManager/Options.swift

@@ -32,6 +32,10 @@ struct Options {
     _bridged.enableSimplificationFor(inst.bridged)
   }
 
+  func enableAddressDependencies() -> Bool {
+    _bridged.enableAddressDependencies()
+  }
+
   var enableEmbeddedSwift: Bool {
     _bridged.hasFeature(.Embedded)
   }

include/swift/AST/SILOptions.h

@@ -331,6 +331,10 @@ class SILOptions {
   /// optimizer.
   bool UseAggressiveReg2MemForCodeSize = true;
 
+  /// Enable enforcement of lifetime dependencies on addressable arguments.
+  /// Temporarily used to bootstrap the AddressableParameters feature.
+  bool EnableAddressDependencies = false;
+
   SILOptions() {}
 
   /// Return a hash code of any components from these options that should

include/swift/Option/FrontendOptions.td

@@ -1489,6 +1489,9 @@ def platform_availability_inheritance_map_path
   : Separate<["-"], "platform-availability-inheritance-map-path">, MetaVarName<"<path>">,
     HelpText<"Path of the platform inheritance platform map">;
 
+def enable_address_dependencies : Flag<["-"], "enable-address-dependencies">,
+  HelpText<"Enable enforcement of lifetime dependencies on addressable values.">;
+
 } // end let Flags = [FrontendOption, NoDriverOption, HelpHidden]
 
 def disable_experimental_parser_round_trip : Flag<["-"],

include/swift/SILOptimizer/OptimizerBridging.h

@@ -382,6 +382,9 @@ struct BridgedPassContext {
   bool enableSimplificationFor(BridgedInstruction inst) const;
   BRIDGED_INLINE bool enableWMORequiredDiagnostics() const;
 
+  // Temporary for AddressableParameters Bootstrapping.
+  BRIDGED_INLINE bool enableAddressDependencies() const;
+
   // Closure specializer
   SWIFT_IMPORT_UNSAFE BridgedFunction ClosureSpecializer_createEmptyFunctionWithSpecializedSignature(BridgedStringRef specializedName,
                                                         const BridgedParameterInfo * _Nullable specializedBridgedParams,

include/swift/SILOptimizer/OptimizerBridgingImpl.h

@@ -573,6 +573,11 @@ bool BridgedPassContext::enableWMORequiredDiagnostics() const {
   return mod->getOptions().EnableWMORequiredDiagnostics;
 }
 
+bool BridgedPassContext::enableAddressDependencies() const {
+  swift::SILModule *mod = invocation->getPassManager()->getModule();
+  return mod->getOptions().EnableAddressDependencies;
+}
+
 static_assert((int)BridgedPassContext::SILStage::Raw == (int)swift::SILStage::Raw);
 static_assert((int)BridgedPassContext::SILStage::Canonical == (int)swift::SILStage::Canonical);
 static_assert((int)BridgedPassContext::SILStage::Lowered == (int)swift::SILStage::Lowered);

lib/DriverTool/sil_opt_main.cpp

@@ -592,6 +592,10 @@ struct SILOptOptions {
       "swift-version",
       llvm::cl::desc(
           "The swift version to assume AST declarations correspond to"));
+
+  llvm::cl::opt<bool> EnableAddressDependencies = llvm::cl::opt<bool>(
+      "enable-address-dependencies",
+      llvm::cl::desc("Enable enforcement of lifetime dependencies on addressable values."));
 };
 
 /// Regular expression corresponding to the value given in one of the
@@ -909,6 +913,8 @@ int sil_opt_main(ArrayRef<const char *> argv, void *MainAddr) {
   SILOpts.EnablePackMetadataStackPromotion =
       options.EnablePackMetadataStackPromotion;
 
+  SILOpts.EnableAddressDependencies = options.EnableAddressDependencies;
+
   if (options.OptModeFlag == OptimizationMode::NotSet) {
     if (options.OptimizationGroup == OptGroup::Diagnostics)
       SILOpts.OptMode = OptimizationMode::NoOptimization;

lib/Frontend/CompilerInvocation.cpp

@@ -3013,6 +3013,9 @@ static bool ParseSILArgs(SILOptions &Opts, ArgList &Args,
     Opts.ShouldFunctionsBePreservedToDebugger &=
         LTOKind.value() == IRGenLLVMLTOKind::None;
 
+  
+  Opts.EnableAddressDependencies = Args.hasArg(OPT_enable_address_dependencies);
+
   return false;
 }