[Distributed] Don't duplicate hasUserDefinedInit entry, less guards

Author: ktoso

include/swift/AST/Decl.h

@@ -3370,12 +3370,6 @@ class NominalTypeDecl : public GenericTypeDecl, public IterableDeclContext {
   /// for types that are not global actors.
   VarDecl *getGlobalActorInstance() const;
 
-  /// Check if the declaration has an user-defined initializer.
-  /// If so, we may want to e.g. not generate a default initializer etc.
-  ///
-  /// \returns true if the decl has an user-defined designated initializer.
-  bool hasUserDefinedDesignatedInit() const;
-
   /// Whether this type is a global actor, which can be used as an
   /// attribute to decorate declarations for inclusion in the actor-isolated
   /// state denoted by this type.

lib/AST/Decl.cpp

@@ -4208,18 +4208,6 @@ ConstructorDecl *NominalTypeDecl::getDefaultInitializer() const {
                            SynthesizeDefaultInitRequest{mutableThis}, nullptr);
 }
 
-bool NominalTypeDecl::hasUserDefinedDesignatedInit() const {
-  // Imported decls don't have a designated initializer defined by the user.
-  if (hasClangNode())
-    return false;
-
-  auto &ctx = getASTContext();
-  auto *mutableThis = const_cast<NominalTypeDecl *>(this);
-  return evaluateOrDefault(ctx.evaluator,
-                           HasUserDefinedDesignatedInitRequest{mutableThis},
-                           false);
-}
-
 void NominalTypeDecl::synthesizeSemanticMembersIfNeeded(DeclName member) {
   // Silently break cycles here because we can't be sure when and where a
   // request to synthesize will come from yet.

lib/Sema/CodeSynthesis.cpp

@@ -996,8 +996,6 @@ HasUserDefinedDesignatedInitRequest::evaluate(Evaluator &evaluator,
   return false;
 }
 
-// TODO(distributed): duplicated of NominalTypeDecl::hasUserDefinedDesignatedInit,
-//                    remove this static version?
 static bool hasUserDefinedDesignatedInit(Evaluator &eval,
                                          NominalTypeDecl *decl) {
   // Imported decls don't have a designated initializer defined by the user.

lib/Sema/TypeCheckDistributed.cpp

@@ -173,9 +173,6 @@ void swift::checkDistributedActorConstructor(const ClassDecl *decl, ConstructorD
   if (!ctor->isDesignatedInit())
     return;
 
-  if (!swift::ensureDistributedModuleLoaded(ctor))
-    return;
-
   // === Designated initializers must accept exactly one ActorTransport
   auto &C = ctor->getASTContext();
   auto module = ctor->getParentModule();

stdlib/public/Concurrency/Actor.cpp

@@ -1971,6 +1971,10 @@ swift::swift_distributedActor_remote_initialize(const Metadata *actorType) {
                                         classMetadata->getInstanceSize(),
                                         classMetadata->getInstanceAlignMask());
 
+  // TODO: remove this memset eventually, today we only do this to not have
+  //       to modify the destructor logic, as releasing zeroes is no-op
+  memset(alloc + 1, 0, classMetadata->getInstanceSize() - sizeof(HeapObject));
+
   // TODO(distributed): a remote one does not have to have the "real"
   //  default actor body, e.g. we don't need an executor at all; so
   //  we can allocate more efficiently and only share the flags/status field

test/SIL/Distributed/distributed_actor_default_deinit_sil.swift

@@ -1,4 +1,4 @@
-// RUN: %target-swift-frontend -O -primary-file %s -emit-sil -enable-experimental-distributed | %FileCheck %s --dump-input=always
+// RUN: %target-swift-frontend -O -primary-file %s -emit-sil -enable-experimental-distributed | %FileCheck %s
 
 import _Distributed