Merge pull request #36877 from xedin/rdar-76250381

[ConstraintSystem] Allow fixing r-value -> l-value mismatch without a…

Author: xedin

lib/Sema/CSSimplify.cpp

@@ -3667,6 +3667,12 @@ bool ConstraintSystem::repairFailures(
                                TMF_ApplyingFix, locator);
 
       if (result.isSuccess()) {
+        // If left side is a hole, let's not record a fix since hole can
+        // assume any type and already represents a problem elsewhere in
+        // the expression.
+        if (lhs->isPlaceholder())
+          return true;
+
         conversionsOrFixes.push_back(
             TreatRValueAsLValue::create(*this, getConstraintLocator(locator)));
         return true;

test/Constraints/closures.swift

@@ -1084,3 +1084,16 @@ var emptyBodyMismatch: () -> Int {
     return
   }
 }
+
+// rdar://76250381 - crash when passing an argument to a closure that takes no arguments
+struct R_76250381<Result, Failure: Error> {
+  func test(operation: @escaping () -> Result) -> Bool {
+    return try self.crash { group in // expected-error {{contextual closure type '() -> Result' expects 0 arguments, but 1 was used in closure body}}
+      operation(&group) // expected-error {{argument passed to call that takes no arguments}}
+    }
+  }
+
+  func crash(_: @escaping () -> Result) -> Bool {
+    return false
+  }
+}