Merge pull request #85807 from allevato/more-json-ast-fixes-2

[ASTDumper] Fix malformed JSON for `async let _ = ...`.

Author: allevato

lib/AST/ASTDumper.cpp

@@ -1913,10 +1913,8 @@ namespace {
       printFoot();
     }
     void visitAnyPattern(AnyPattern *P, Label label) {
-      if (P->isAsyncLet()) {
-        printCommon(P, "async_let ", label);
-      }
       printCommon(P, "pattern_any", label);
+      printFlag(P->isAsyncLet(), "async_let", DeclModifierColor);
       printFoot();
     }
     void visitTypedPattern(TypedPattern *P, Label label) {

test/Frontend/ast-dump-json-no-crash.swift

@@ -503,3 +503,11 @@ func outerFn() {
     }
     innerFun(shouldRecurse: true)
 }
+
+// Regression test: Discarded async lets were calling `printCommon` twice,
+// which resulted in invalid JSON (and not-so-great S-expression output)
+// either.
+func discardedAsyncLet() async {
+    func someTask() async {}
+    async let _ = someTask()
+}