Merge pull request #41071 from gottesmm/pr-b273bb7d8a0817065f099d4e76915e1ceb6eff0c

[move-only] Move move function kills values checking and move only value lifetime checking before diagnostic constant prop.

Author: gottesmm

lib/SILOptimizer/PassManager/PassPipeline.cpp

@@ -157,6 +157,12 @@ static void addMandatoryDiagnosticOptPipeline(SILPassPipelinePlan &P) {
   // SSA based diagnostics.
   P.addPredictableMemoryAccessOptimizations();
 
+  // Now that we have promoted simple loads for SSA based diagnostics, perform
+  // SSA based move function checking and no implicit copy checking.
+  P.addMoveKillsCopyableValuesChecker(); // No uses after _move of copyable
+                                         //   value.
+  P.addMoveOnlyChecker();                // Check noImplicitCopy isn't copied.
+
   // This phase performs optimizations necessary for correct interoperation of
   // Swift os log APIs with C os_log ABIs.
   // Pass dependencies: this pass depends on MandatoryInlining and Mandatory
@@ -173,11 +179,6 @@ static void addMandatoryDiagnosticOptPipeline(SILPassPipelinePlan &P) {
   // dead allocations.
   P.addPredictableDeadAllocationElimination();
 
-  // Now perform move semantic checking.
-  P.addMoveKillsCopyableValuesChecker(); // No uses after _move of copyable
-                                         //   value.
-  P.addMoveOnlyChecker();                // Check noImplicitCopy isn't copied.
-
   // Now that we have finished performing diagnostics that rely on lexical
   // scopes, if lexical lifetimes are not enabled, eliminate lexical lfietimes.
   if (Options.LexicalLifetimes != LexicalLifetimesOption::On) {