SILOptimizer: address C5030

compnerd · compnerd · commit 4097255ea5d0 · 2025-02-07T15:04:38.000-08:00
i```
swift\lib\SILOptimizer\Mandatory\MoveOnlyAddressCheckerUtils.cpp(2981): warning C5030: attribute [[clang::fallthrough]] is not recognized
```

Replace the use of `clang::fallthrough` with `LLVM_FALLTHROUGH` which
properly uses the C++ standard spelling (`[[fallthrough]]`) depending on
the compiler version.
diff --git a/lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerUtils.cpp b/lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerUtils.cpp
@@ -2979,7 +2979,7 @@ bool GlobalLivenessChecker::testInstVectorLiveness(
             LLVM_DEBUG(llvm::dbgs() << "    Also a def block; skipping!\n");
             continue;
           }
-          [[clang::fallthrough]];
+          LLVM_FALLTHROUGH;
         }
         case IsLive::LiveWithin:
           if (isLive == IsLive::LiveWithin)

Original file line number	Diff line number	Diff line change
`@@ -2979,7 +2979,7 @@ bool GlobalLivenessChecker::testInstVectorLiveness(`
`2979`	`2979`	`LLVM_DEBUG(llvm::dbgs() << " Also a def block; skipping!\n");`
`2980`	`2980`	`continue;`
`2981`	`2981`	`}`
`2982`		`- [[clang::fallthrough]];`
	`2982`	`+ LLVM_FALLTHROUGH;`
`2983`	`2983`	`}`
`2984`	`2984`	`case IsLive::LiveWithin:`
`2985`	`2985`	`if (isLive == IsLive::LiveWithin)`