Don't crash if there's a request cycle with DefaultArgumentExprRequest.

Author: rjmccall

lib/AST/Decl.cpp

@@ -9443,7 +9443,18 @@ void ParamDecl::setDefaultExpr(Expr *E) {
 }
 
 void ParamDecl::setTypeCheckedDefaultExpr(Expr *E) {
-  assert(E || getDefaultArgumentKind() == DefaultArgumentKind::Inherited);
+  // The type-checker will only produce a null expression here if the
+  // default argument is inherited, so if we're called with a null pointer
+  // in any other case, it must be from a request cycle. Don't crash;
+  // just wrap the original expression with an ErrorExpr and proceed.
+  if (!E && getDefaultArgumentKind() != DefaultArgumentKind::Inherited) {
+    auto *initExpr = getStructuralDefaultExpr();
+    assert(initExpr);
+    auto &ctx = getASTContext();
+    E = new (ctx) ErrorExpr(initExpr->getSourceRange(), ErrorType::get(ctx),
+                            initExpr);
+  }
+
   setDefaultExpr(E);
 
   auto *defaultInfo = DefaultValueAndFlags.getPointer();

…mpiler_crashers_2/8d73bb4170a0c447.swift …_crashers_2_fixed/8d73bb4170a0c447.swiftvalidation-test/compiler_crashers_2/8d73bb4170a0c447.swift renamed to validation-test/compiler_crashers_2_fixed/8d73bb4170a0c447.swift validation-test/compiler_crashers_2/8d73bb4170a0c447.swift renamed to validation-test/compiler_crashers_2_fixed/8d73bb4170a0c447.swift

@@ -1,3 +1,3 @@
 // {"kind":"typecheck","signature":"swift::ParamDecl::setTypeCheckedDefaultExpr(swift::Expr*)","signatureAssert":"Assertion failed: (E || getDefaultArgumentKind() == DefaultArgumentKind::Inherited), function setTypeCheckedDefaultExpr"}
-// RUN: not --crash %target-swift-frontend -typecheck %s
+// RUN: not %target-swift-frontend -typecheck %s
 func a<b>(b= a(