[embedded] Tighten the check which existentials we support in embedded with existentials

aschwaighofer · aschwaighofer · commit 01977846253d · 2025-11-20T07:55:51.000-08:00
diff --git a/SwiftCompilerSources/Sources/Optimizer/ModulePasses/EmbeddedSwiftDiagnostics.swift b/SwiftCompilerSources/Sources/Optimizer/ModulePasses/EmbeddedSwiftDiagnostics.swift
@@ -94,6 +94,11 @@ private struct FunctionChecker {
         for conf in ie.conformances {
           try checkConformance(conf, location: ie.location)
         }
+      } else if instruction is OpenExistentialAddrInst {
+          // okay in embedded with exitentials
+      } else {
+          // not supported even in embedded with exitentials
+        throw Diagnostic(.embedded_swift_existential_type, instruction.operands[0].value.type, at: instruction.location)
       }
 
     case let aeb as AllocExistentialBoxInst:

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,11 @@ private struct FunctionChecker {`
`94`	`94`	`for conf in ie.conformances {`
`95`	`95`	`try checkConformance(conf, location: ie.location)`
`96`	`96`	`}`
	`97`	`+ } else if instruction is OpenExistentialAddrInst {`
	`98`	`+ // okay in embedded with exitentials`
	`99`	`+ } else {`
	`100`	`+ // not supported even in embedded with exitentials`
	`101`	`+ throw Diagnostic(.embedded_swift_existential_type, instruction.operands[0].value.type, at: instruction.location)`
`97`	`102`	`}`
`98`	`103`
`99`	`104`	`case let aeb as AllocExistentialBoxInst:`