Disable LockTests.testReadWriteFileLock

benlangmuir · benlangmuir · commit fa1ce62534ad · 2021-05-25T09:45:52.000-07:00
This test may fail spuriously if a reader thread runs before any writers
were able to write the initial value to the file. Disable the test until
it can be fixed. We saw the same issue with FileSystemTests in the past.

rdar://78461378
diff --git a/Tests/TSCBasicTests/LockTests.swift b/Tests/TSCBasicTests/LockTests.swift
@@ -61,6 +61,7 @@ class LockTests: XCTestCase {
     }
 
     func testReadWriteFileLock() throws {
+        try XCTSkipIf(true, "fails spuriously if reader thread beats first writer rdar://78461378")
         try withTemporaryDirectory { tempDir in
             let fileA = tempDir.appending(component: "fileA")
             let fileB = tempDir.appending(component: "fileB")

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ class LockTests: XCTestCase {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`func testReadWriteFileLock() throws {`
	`64`	`+ try XCTSkipIf(true, "fails spuriously if reader thread beats first writer rdar://78461378")`
`64`	`65`	`try withTemporaryDirectory { tempDir in`
`65`	`66`	`let fileA = tempDir.appending(component: "fileA")`
`66`	`67`	`let fileB = tempDir.appending(component: "fileB")`