Fix tests

Author: stevapple

Tests/TSCBasicTests/ProcessTests.swift

@@ -108,12 +108,13 @@ class ProcessTests: XCTestCase {
     }
 
     func testFindExecutable() throws {
+      #if !os(Windows)
         try testWithTemporaryDirectory { tmpdir in
             // This process should always work.
-            XCTAssertTrue(Process.findExecutable("ls") != nil)
+            XCTAssertNotNil(Process.findExecutable("ls"))
 
-            XCTAssertEqual(Process.findExecutable("nonExistantProgram"), nil)
-            XCTAssertEqual(Process.findExecutable(""), nil)
+            XCTAssertNil(Process.findExecutable("nonExistantProgram"))
+            XCTAssertNil(Process.findExecutable(""))
 
             // Create a local nonexecutable file to test.
             let tempExecutable = tmpdir.appending(component: "nonExecutableProgram")
@@ -124,11 +125,37 @@ class ProcessTests: XCTestCase {
                 """)
 
             try withCustomEnv(["PATH": tmpdir.pathString]) {
-                XCTAssertEqual(Process.findExecutable("nonExecutableProgram"), nil)
+                XCTAssertNil(Process.findExecutable("nonExecutableProgram"))
             }
         }
+      #else
+        try testWithTemporaryDirectory { tmpdir in
+            // Test System32 without .exe suffix.
+            XCTAssertNotNil(Process.findExecutable("cmd"))
+            
+            // Test Windows with .exe suffix.
+            XCTAssertNotNil(Process.findExecutable("explorer.exe"))
+
+            // Test non-existant programs.
+            XCTAssertNil(Process.findExecutable("nonExistantProgram"))
+            XCTAssertNil(Process.findExecutable(""))
+
+            // Create a bat file to test.
+            let tempExecutable = tmpdir.appending(component: "program.bat")
+            try localFileSystem.writeFileContents(tempExecutable, bytes: """
+                @echo off
+                exit
+
+                """)
+
+            try withCustomEnv(["PATH": tmpdir.pathString]) {
+                XCTAssertNotNil(Process.findExecutable("program.bat"))
+            }
+        }
+      #endif
     }
 
+  #if !os(Windows) // Foundation treats all readable files as executable on Windows.
     func testNonExecutableLaunch() throws {
         try testWithTemporaryDirectory { tmpdir in
             // Create a local nonexecutable file to test.
@@ -150,6 +177,7 @@ class ProcessTests: XCTestCase {
             }
         }
     }
+  #endif
 
   #if !os(Windows) // Signals are not supported in Windows
     func testSignals() throws {