Fix warnings

This was a combo of deprecations and normal warnings, but all seem safe
to fix.

Author: keith

Sources/TSCUtility/Version.swift

@@ -137,7 +137,7 @@ extension Version {
         if let prereleaseDelimiterIndex = prereleaseDelimiterIndex {
             let prereleaseStartIndex = versionString.index(after: prereleaseDelimiterIndex)
             let prereleaseIdentifiers = versionString[prereleaseStartIndex..<(metadataDelimiterIndex ?? versionString.endIndex)].split(separator: ".", omittingEmptySubsequences: false)
-            guard prereleaseIdentifiers.allSatisfy( { $0.allSatisfy { $0.isLetter || $0.isNumber || $0 == "-" } } ) else {
+            guard prereleaseIdentifiers.allSatisfy( { $0.allSatisfy({ $0.isLetter || $0.isNumber || $0 == "-" }) } ) else {
                 throw VersionError.nonAlphaNumerHyphenalPrereleaseIdentifiers(prereleaseIdentifiers.map { String($0) })
             }
             self.prereleaseIdentifiers = prereleaseIdentifiers.map { String($0) }
@@ -148,7 +148,7 @@ extension Version {
         if let metadataDelimiterIndex = metadataDelimiterIndex {
             let metadataStartIndex = versionString.index(after: metadataDelimiterIndex)
             let buildMetadataIdentifiers = versionString[metadataStartIndex...].split(separator: ".", omittingEmptySubsequences: false)
-            guard buildMetadataIdentifiers.allSatisfy( { $0.allSatisfy { $0.isLetter || $0.isNumber || $0 == "-" } } ) else {
+            guard buildMetadataIdentifiers.allSatisfy( { $0.allSatisfy({ $0.isLetter || $0.isNumber || $0 == "-" }) } ) else {
                 throw VersionError.nonAlphaNumerHyphenalBuildMetadataIdentifiers(buildMetadataIdentifiers.map { String($0) })
             }
             self.buildMetadataIdentifiers = buildMetadataIdentifiers.map { String($0) }

Tests/TSCUtilityTests/VersionTests.swift

@@ -1454,15 +1454,15 @@ class VersionTests: XCTestCase {
             "-1.2.3", "1.-2.3", "1.2.-3", ".1.2.3", "v.1.2.3", "1.2..3", "v1.2.3",
         ]
         for str in badStrings {
-            XCTAssertNil(Version(string: str))
+            XCTAssertNil(Version(str))
         }
 
-        XCTAssertEqual(Version(1,2,3), Version(string: "1.2.3"))
-        XCTAssertEqual(Version(1,2,3), Version(string: "01.002.0003"))
-        XCTAssertEqual(Version(0,9,21), Version(string: "0.9.21"))
+        XCTAssertEqual(Version(1,2,3), Version("1.2.3"))
+        XCTAssertEqual(Version(1,2,3), Version("01.002.0003"))
+        XCTAssertEqual(Version(0,9,21), Version("0.9.21"))
         XCTAssertEqual(Version(0,9,21, prereleaseIdentifiers: ["alpha", "beta"], buildMetadataIdentifiers: ["1011"]),
-            Version(string: "0.9.21-alpha.beta+1011"))
-        XCTAssertEqual(Version(0,9,21, prereleaseIdentifiers: [], buildMetadataIdentifiers: ["1011"]), Version(string: "0.9.21+1011"))
+            Version("0.9.21-alpha.beta+1011"))
+        XCTAssertEqual(Version(0,9,21, prereleaseIdentifiers: [], buildMetadataIdentifiers: ["1011"]), Version("0.9.21+1011"))
     }
 
     func testRange() {

Tests/TSCUtilityTests/miscTests.swift

@@ -30,17 +30,17 @@ class miscTests: XCTestCase {
 
     func testVersion() throws {
         // Valid.
-        XCTAssertEqual(Version(string: "0.9.21-alpha.beta+1011"),
+        XCTAssertEqual(Version("0.9.21-alpha.beta+1011"),
             Version(0,9,21, prereleaseIdentifiers: ["alpha", "beta"], buildMetadataIdentifiers: ["1011"]))
-        XCTAssertEqual(Version(string: "0.9.21+1011"),
+        XCTAssertEqual(Version("0.9.21+1011"),
             Version(0,9,21, prereleaseIdentifiers: [], buildMetadataIdentifiers: ["1011"]))
-        XCTAssertEqual(Version(string: "01.002.0003"), Version(1,2,3))
-        XCTAssertEqual(Version(string: "0.9.21"), Version(0,9,21))
+        XCTAssertEqual(Version("01.002.0003"), Version(1,2,3))
+        XCTAssertEqual(Version("0.9.21"), Version(0,9,21))
 
         // Invalid.
         let invalidVersions = ["foo", "1", "1.0", "1.0.", "1.0.0."]
         for v in invalidVersions {
-            XCTAssertTrue(Version(string: v) == nil)
+            XCTAssertTrue(Version(v) == nil)
         }
     }
 }