TSCBasic: deprecate AbsolutePath.appending(_:) (#299)

compnerd · web-flow · commit d67baa2392b7 · 2022-03-21T14:57:11.000-07:00
This deprecates the `AbsolutePath.appending(_:)` overload for constructing an `AbsolutePath` by appending a `RelativePath`. Users should prefer `AbsolutePath(_:relativeTo:)`. Addresses feedback from swiftlang/swift-package-manager#4237
diff --git a/Sources/TSCBasic/Path.swift b/Sources/TSCBasic/Path.swift
@@ -166,6 +166,7 @@ public struct AbsolutePath: Hashable {
     }
 
     /// Returns the absolute path with the relative path applied.
+    @available(*, deprecated, renamed: "AbsolutePath(_:relativeTo:)")
     public func appending(_ subpath: RelativePath) -> AbsolutePath {
         return AbsolutePath(self, subpath)
     }

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,7 @@ public struct AbsolutePath: Hashable {`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`/// Returns the absolute path with the relative path applied.`
	`169`	`+ @available(*, deprecated, renamed: "AbsolutePath(_:relativeTo:)")`
`169`	`170`	`public func appending(_ subpath: RelativePath) -> AbsolutePath {`
`170`	`171`	`return AbsolutePath(self, subpath)`
`171`	`172`	`}`