Use a concurrent queue to wait for process completion (#450)

Calling blocking `waitpid` on Swift concurrency threads can cause freezes for `async` code when spawning too many processes with the existing `Process` API.

Author: MaxDesiatov

Sources/TSCBasic/CMakeLists.txt

@@ -37,9 +37,9 @@ add_library(TSCBasic
   WritableByteStream.swift
   Path.swift
   PathShims.swift
-  Process.swift
-  ProcessEnv.swift
-  ProcessSet.swift
+  Process/Process.swift
+  Process/ProcessEnv.swift
+  Process/ProcessSet.swift
   RegEx.swift
   Result.swift
   SortedArray.swift

Sources/TSCBasic/Process.swift Sources/TSCBasic/Process/Process.swiftSources/TSCBasic/Process.swift renamed to Sources/TSCBasic/Process/Process.swift

@@ -130,11 +130,15 @@ public struct ProcessResult: CustomStringConvertible, Sendable {
     }
 }
 
-#if swift(<5.6)
-extension Process: UnsafeSendable {}
-#else
 extension Process: @unchecked Sendable {}
-#endif
+
+extension DispatchQueue {
+    // a shared concurrent queue for running concurrent asynchronous operations
+    static let processConcurrent = DispatchQueue(
+        label: "swift.org.swift-tsc.process.concurrent",
+        attributes: .concurrent
+    )
+}
 
 /// Process allows spawning new subprocesses and working with them.
 ///
@@ -829,25 +833,15 @@ public final class Process {
     @available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)
     @discardableResult
     public func waitUntilExit() async throws -> ProcessResult {
-        #if compiler(>=5.6)
-        return try await withCheckedThrowingContinuation { continuation in
-            waitUntilExit(continuation.resume(with:))
-        }
-        #else
-        if #available(macOS 12.0, iOS 15.0, tvOS 15.0, watchOS 8.0, *) {
-            return try await withCheckedThrowingContinuation { continuation in
-                waitUntilExit(continuation.resume(with:))
+        try await withCheckedThrowingContinuation { continuation in
+            DispatchQueue.processConcurrent.async {
+                self.waitUntilExit(continuation.resume(with:))
             }
-        } else {
-            preconditionFailure("Unsupported with Swift 5.5 on this OS version")
         }
-        #endif
     }
 
     /// Blocks the calling process until the subprocess finishes execution.
-//    #if compiler(>=5.8)
-//    @available(*, noasync)
-//    #endif
+    @available(*, noasync)
     @discardableResult
     public func waitUntilExit() throws -> ProcessResult {
         let group = DispatchGroup()

Sources/TSCBasic/ProcessEnv.swift Sources/TSCBasic/Process/ProcessEnv.swiftSources/TSCBasic/ProcessEnv.swift renamed to Sources/TSCBasic/Process/ProcessEnv.swift

@@ -11,7 +11,7 @@
 import Foundation
 import TSCLibc
 
-/// Provides functionality related a process's enviorment.
+/// Provides functionality related a process's environment.
 public enum ProcessEnv {
 
     /// Returns a dictionary containing the current environment.