Check for delimiter before lookahead in advanceIfMultilineStringDelimiter
#3199
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…miter` Avoid doing an unnecessary lookahead if we're not even at a multiline delimiter. This also fixes an issue where we'd scan ahead on the next line for `#"\n`, although this was benign in practice since the delimiter check would have previously then failed afterwards.
hamishknight
requested review from
ahoppen,
bnbarham and
rintaro
as code owners
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid doing an unnecessary lookahead if we're not even at a multiline delimiter. This also fixes an issue where we'd scan ahead on the next line for
#"\n, although this was benign in practice since the delimiter check would have previously then failed afterwards. This matches the logic in swiftlang/swift#85889.