Merge pull request #2052 from ahoppen/ahoppen/key-path-property-compatibility

Improve compatibility layer for `KeyPathPropertyComponentSyntax`

Author: ahoppen

CodeGeneration/Sources/SyntaxSupport/ExprNodes.swift

@@ -1090,7 +1090,6 @@ public let EXPR_NODES: [Node] = [
     children: [
       Child(
         name: "DeclName",
-        deprecatedName: "Identifier",
         kind: .node(kind: .declReferenceExpr)
       ),
       Child(

Sources/SwiftSyntax/SwiftSyntaxCompatibility.swift

@@ -70,6 +70,28 @@ extension GenericRequirementSyntax {
 @available(*, deprecated, renamed: "NamedDeclSyntax")
 public typealias IdentifiedDeclSyntax = NamedDeclSyntax
 
+extension KeyPathPropertyComponentSyntax {
+  @available(*, deprecated, renamed: "declName.baseName")
+  public var identifier: TokenSyntax {
+    get {
+      return declName.baseName
+    }
+    set {
+      declName.baseName = newValue
+    }
+  }
+
+  @available(*, deprecated, renamed: "declName.argumentNames")
+  public var declNameArguments: DeclNameArgumentsSyntax? {
+    get {
+      return declName.argumentNames
+    }
+    set {
+      declName.argumentNames = newValue
+    }
+  }
+}
+
 extension NamedDeclSyntax {
   @available(*, deprecated, renamed: "name")
   public var identifier: TokenSyntax {

Sources/SwiftSyntax/generated/RenamedChildrenCompatibility.swift

@@ -4404,61 +4404,6 @@ extension IsExprSyntax {
   }
 }
 
-extension KeyPathPropertyComponentSyntax {
-  @available(*, deprecated, renamed: "unexpectedBeforeDeclName")
-  public var unexpectedBeforeIdentifier: UnexpectedNodesSyntax? {
-    get {
-      return unexpectedBeforeDeclName
-    }
-    set {
-      unexpectedBeforeDeclName = newValue
-    }
-  }
-  
-  @available(*, deprecated, renamed: "declName")
-  public var identifier: DeclReferenceExprSyntax {
-    get {
-      return declName
-    }
-    set {
-      declName = newValue
-    }
-  }
-  
-  @available(*, deprecated, renamed: "unexpectedBetweenDeclNameAndGenericArgumentClause")
-  public var unexpectedBetweenIdentifierAndGenericArgumentClause: UnexpectedNodesSyntax? {
-    get {
-      return unexpectedBetweenDeclNameAndGenericArgumentClause
-    }
-    set {
-      unexpectedBetweenDeclNameAndGenericArgumentClause = newValue
-    }
-  }
-  
-  @available(*, deprecated, renamed: "KeyPathPropertyComponentSyntax(leadingTrivia:_:declName:_:genericArgumentClause:_:trailingTrivia:)")
-  @_disfavoredOverload
-  public init(
-      leadingTrivia: Trivia? = nil,
-      _ unexpectedBeforeIdentifier: UnexpectedNodesSyntax? = nil,
-      identifier: DeclReferenceExprSyntax,
-      _ unexpectedBetweenIdentifierAndGenericArgumentClause: UnexpectedNodesSyntax? = nil,
-      genericArgumentClause: GenericArgumentClauseSyntax? = nil,
-      _ unexpectedAfterGenericArgumentClause: UnexpectedNodesSyntax? = nil,
-      trailingTrivia: Trivia? = nil
-    
-  ) {
-    self.init(
-        leadingTrivia: leadingTrivia, 
-        unexpectedBeforeIdentifier, 
-        declName: identifier, 
-        unexpectedBetweenIdentifierAndGenericArgumentClause, 
-        genericArgumentClause: genericArgumentClause, 
-        unexpectedAfterGenericArgumentClause, 
-        trailingTrivia: trailingTrivia
-      )
-  }
-}
-
 extension KeyPathSubscriptComponentSyntax {
   @available(*, deprecated, renamed: "unexpectedBeforeLeftSquare")
   public var unexpectedBeforeLeftBracket: UnexpectedNodesSyntax? {