Add development-time assertions to catch errors where two llbuild commands are created with the same name. Otherwise this results in silently replacing some commands in the graph. We can discuss whether a future improvement would be to make these internal errors reported at runtime. (#3587)

Author: abertelrud

Sources/LLBuildManifest/BuildManifest.swift

@@ -50,6 +50,7 @@ public struct BuildManifest {
         inputs: [Node],
         outputs: [Node]
     ) {
+        assert(commands[name] == nil, "aleady had a command named '\(name)'")
         let tool = PhonyTool(inputs: inputs, outputs: outputs)
         commands[name] = Command(name: name, tool: tool)
     }
@@ -59,6 +60,7 @@ public struct BuildManifest {
         inputs: [Node],
         outputs: [Node]
     ) {
+        assert(commands[name] == nil, "aleady had a command named '\(name)'")
         let tool = TestDiscoveryTool(inputs: inputs, outputs: outputs)
         commands[name] = Command(name: name, tool: tool)
     }
@@ -68,6 +70,7 @@ public struct BuildManifest {
         inputs: [Node],
         outputs: [Node]
     ) {
+        assert(commands[name] == nil, "aleady had a command named '\(name)'")
         let tool = CopyTool(inputs: inputs, outputs: outputs)
         commands[name] = Command(name: name, tool: tool)
     }
@@ -77,6 +80,7 @@ public struct BuildManifest {
         inputs: [Node],
         outputs: [Node]
     ) {
+        assert(commands[name] == nil, "aleady had a command named '\(name)'")
         let tool = PackageStructureTool(inputs: inputs, outputs: outputs)
         commands[name] = Command(name: name, tool: tool)
     }
@@ -86,6 +90,7 @@ public struct BuildManifest {
         inputs: [Node],
         outputs: [Node]
     ) {
+        assert(commands[name] == nil, "aleady had a command named '\(name)'")
         let tool = ArchiveTool(inputs: inputs, outputs: outputs)
         commands[name] = Command(name: name, tool: tool)
     }
@@ -100,6 +105,7 @@ public struct BuildManifest {
         workingDirectory: String? = nil,
         allowMissingInputs: Bool = false
     ) {
+        assert(commands[name] == nil, "aleady had a command named '\(name)'")
         let tool = ShellTool(
             description: description,
             inputs: inputs,
@@ -120,6 +126,7 @@ public struct BuildManifest {
         outputs: [Node],
         arguments: [String]
     ) {
+        assert(commands[name] == nil, "aleady had a command named '\(name)'")
         let tool = SwiftFrontendTool(
                 moduleName: moduleName,
                 description: description,
@@ -138,6 +145,7 @@ public struct BuildManifest {
         arguments: [String],
         dependencies: String? = nil
     ) {
+        assert(commands[name] == nil, "aleady had a command named '\(name)'")
         let tool = ClangTool(
             description: description,
             inputs: inputs,
@@ -163,6 +171,7 @@ public struct BuildManifest {
         isLibrary: Bool,
         wholeModuleOptimization: Bool
     ) {
+        assert(commands[name] == nil, "aleady had a command named '\(name)'")
         let tool = SwiftCompilerTool(
             inputs: inputs,
             outputs: outputs,
@@ -177,7 +186,6 @@ public struct BuildManifest {
             isLibrary: isLibrary,
             wholeModuleOptimization: wholeModuleOptimization
         )
-      
         commands[name] = Command(name: name, tool: tool)
     }
 }