Merge pull request #374 from davidungar/tempDir

Ensure temp dir is different between testIncremental and testIncrementalDiagnostics to see if that fixes the test breakage in CI

Author: David Ungar

Tests/SwiftDriverTests/IncrementalCompilationTests.swift

@@ -341,7 +341,12 @@ final class IncrementalCompilationTests: XCTestCase {
   }
 
   override func setUp() {
-    self.tempDir = try! withTemporaryDirectory(removeTreeOnDeinit: false) {$0}
+    // Prefix directory with test name to ensure directory name is unique when
+    // testing in parallel.
+    // name returns e.g. "[SwiftDriverTests.IncrementalCompilationTests testIncremental]
+    // but we just want "testIncremental"
+    let testName = name.split(separator: " ").last!.dropLast()
+    self.tempDir = try! withTemporaryDirectory(prefix: String(testName),  removeTreeOnDeinit: false) {$0}
     try! localFileSystem.createDirectory(derivedDataPath)
     writeOutputFileMapData(module: module,
                            inputPaths: inputPathsAndContents.map {$0.0},
@@ -355,11 +360,8 @@ final class IncrementalCompilationTests: XCTestCase {
     }
   }
 
-  // FIXME: why does it fail on Linux in CI?
   func testIncrementalDiagnostics() throws {
-    #if !os(Linux)
     try testIncremental(checkDiagnostics: true)
-    #endif
   }
 
   func testIncremental() throws {