Fix PATH

Author: stevapple

Sources/SwiftDriver/Jobs/Planning.swift

@@ -91,7 +91,7 @@ extension Driver {
       jobsBeforeCompiles.append(job)
     }
 
-    var  compileJobGroups = [CompileJobGroup]()
+    var compileJobGroups = [CompileJobGroup]()
     func addCompileJobGroup(_ group: CompileJobGroup) {
       compileJobGroups.append(group)
     }

Sources/SwiftDriver/Toolchains/GenericUnixToolchain.swift

@@ -21,12 +21,13 @@ import TSCBasic
   /// The file system to use for queries.
   public let fileSystem: FileSystem
 
-  /// Doubles as path cache and point for overriding normal lookup
-  private var toolPaths = [Tool: AbsolutePath]()
-
   // An externally provided path from where we should find compiler
   public let compilerExecutableDir: AbsolutePath?
 
+  /// Doubles as path cache and point for overriding normal lookup
+  private var toolPaths = [Tool: AbsolutePath]()
+
+  // An externally provided path from where we should find tools like ld
   public let toolDirectory: AbsolutePath?
 
   public let dummyForTestingObjectFormat = Triple.ObjectFormat.elf

Sources/SwiftDriver/Toolchains/Toolchain.swift

@@ -102,7 +102,7 @@ public enum Tool: Hashable {
 
 extension Toolchain {
   public var searchPaths: [AbsolutePath] {
-    getEnvSearchPaths(pathString: env["PATH"], currentWorkingDirectory: fileSystem.currentWorkingDirectory)
+    getEnvSearchPaths(pathString: ProcessEnv.path, currentWorkingDirectory: fileSystem.currentWorkingDirectory)
   }
 
   /// Returns the `executablePath`'s directory.

Sources/SwiftDriver/Toolchains/WebAssemblyToolchain.swift

@@ -42,11 +42,13 @@ import SwiftOptions
   /// The file system to use for queries.
   public let fileSystem: FileSystem
 
+  // An externally provided path from where we should find compiler
+  public let compilerExecutableDir: AbsolutePath?
+
   /// Doubles as path cache and point for overriding normal lookup
   private var toolPaths = [Tool: AbsolutePath]()
 
-  public let compilerExecutableDir: AbsolutePath?
-
+  // An externally provided path from where we should find tools like ld
   public let toolDirectory: AbsolutePath?
 
   public let dummyForTestingObjectFormat = Triple.ObjectFormat.wasm

Sources/SwiftDriver/Toolchains/WindowsToolchain.swift

@@ -22,12 +22,12 @@ import SwiftOptions
   /// The file system to use for queries.
   public let fileSystem: FileSystem
 
-  /// Doubles as path cache and point for overriding normal lookup
-  private var toolPaths = [Tool: AbsolutePath]()
-
   // An externally provided path from where we should find compiler
   public let compilerExecutableDir: AbsolutePath?
 
+  /// Doubles as path cache and point for overriding normal lookup
+  private var toolPaths = [Tool: AbsolutePath]()
+
   // An externally provided path from where we should find tools like ld
   public let toolDirectory: AbsolutePath?