Merge pull request #404 from ahoppen/pr/enable-crash-recovery-tests-linux

benlangmuir · web-flow · commit 1e62953514e5 · 2021-05-26T07:51:04.000-07:00
Re-enable clangd crash recovery tests on Linux
diff --git a/Tests/SourceKitDTests/CrashRecoveryTests.swift b/Tests/SourceKitDTests/CrashRecoveryTests.swift
@@ -152,7 +152,6 @@ final class CrashRecoveryTests: XCTestCase {
   }
 
   func testClangdCrashRecovery() throws {
-    try XCTSkipUnless(isDarwinHost, "Crashing sporadically rdar://78035044")
     try XCTSkipUnless(longTestsEnabled)
 
     let ws = try! staticSourceKitTibsWorkspace(name: "ClangCrashRecovery")!
@@ -190,7 +189,6 @@ final class CrashRecoveryTests: XCTestCase {
   }
     
   func testClangdCrashRecoveryReopensWithCorrectBuildSettings() throws {
-    try XCTSkipUnless(isDarwinHost, "Crashing sporadically rdar://78035044")
     try XCTSkipUnless(longTestsEnabled)
 
     let ws = try! staticSourceKitTibsWorkspace(name: "ClangCrashRecoveryBuildSettings")!
@@ -224,7 +222,6 @@ final class CrashRecoveryTests: XCTestCase {
   }
   
   func testPreventClangdCrashLoop() throws {
-    try XCTSkipUnless(isDarwinHost, "Crashing sporadically rdar://78035044")
     try XCTSkipUnless(longTestsEnabled)
 
     let ws = try! staticSourceKitTibsWorkspace(name: "ClangCrashRecovery")!

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,6 @@ final class CrashRecoveryTests: XCTestCase {`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`func testClangdCrashRecovery() throws {`
`155`		`- try XCTSkipUnless(isDarwinHost, "Crashing sporadically rdar://78035044")`
`156`	`155`	`try XCTSkipUnless(longTestsEnabled)`
`157`	`156`
`158`	`157`	`let ws = try! staticSourceKitTibsWorkspace(name: "ClangCrashRecovery")!`
`@@ -190,7 +189,6 @@ final class CrashRecoveryTests: XCTestCase {`
`190`	`189`	`}`
`191`	`190`
`192`	`191`	`func testClangdCrashRecoveryReopensWithCorrectBuildSettings() throws {`
`193`		`- try XCTSkipUnless(isDarwinHost, "Crashing sporadically rdar://78035044")`
`194`	`192`	`try XCTSkipUnless(longTestsEnabled)`
`195`	`193`
`196`	`194`	`let ws = try! staticSourceKitTibsWorkspace(name: "ClangCrashRecoveryBuildSettings")!`
`@@ -224,7 +222,6 @@ final class CrashRecoveryTests: XCTestCase {`
`224`	`222`	`}`
`225`	`223`
`226`	`224`	`func testPreventClangdCrashLoop() throws {`
`227`		`- try XCTSkipUnless(isDarwinHost, "Crashing sporadically rdar://78035044")`
`228`	`225`	`try XCTSkipUnless(longTestsEnabled)`
`229`	`226`
`230`	`227`	`let ws = try! staticSourceKitTibsWorkspace(name: "ClangCrashRecovery")!`