Skip to content

Commit 03ec314

Browse files
authored
vscode: address some OOB feedback
Remove the now extraneous `createDevPackage` script in favour of `dev-package`. Update the README.md accordingly. Additionally, restore the ignore rule for the test VSCode instance. The gitignore is already configured to ignore vsix files, and vsce will implicitly ignore the vsix files when packaging so we do not run the risk of committing or distributing the vsix accidentally.
1 parent 80179be commit 03ec314

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

Editors/vscode/.vscodeignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
**/tsconfig.json
33
.gitignore
44
.vscode/
5-
node_modules/
5+
.vscode-test/
6+
node_modules/

Editors/vscode/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ The following commands build the extension and creates a `.vsix` package in the
1919

2020
```
2121
$ cd Editors/vscode
22-
$ npm run createDevPackage
22+
$ npm install
23+
$ npm run dev-package
2324
```
2425

2526
You can install the package from the command-line using the `code` command if available (see [Launching from the command line](https://code.visualstudio.com/docs/setup/mac#_launching-from-the-command-line)).

Editors/vscode/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
"esbuild-watch": "npm run -S esbuild-base -- --sourcemap --watch",
2828
"package": "vsce package",
2929
"dev-package": "vsce package -o sourcekit-lsp-development.vsix",
30-
"createDevPackage": "npm install && ./node_modules/.bin/vsce package -o ./out/sourcekit-lsp-vscode-dev.vsix"
3130
},
3231
"dependencies": {
3332
"vscode-languageclient": "^7.0.0"

0 commit comments

Comments
 (0)