[DRAFT] [LLDB] Add ObjC object typeref support to SwiftRuntimeTypeVisitor #11929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
force-pushed
the
154450536
branch
from
0e52023 to
646d2f3
Compare
Author
|
@swift-ci test |
adrian-prantl
force-pushed
the
154450536
branch
from
646d2f3 to
29e2381
Compare
Author
|
Updated the test, the previous one didn't actually exercise the new code m-( |
Author
|
@swift-ci test |
adrian-prantl
changed the title
This patch moves the disjunct implementations for TypeSystemTypeRef::GetNumFields and GetIndexOfChildMemberWithName into the TypeRef visitor, so they behave consistently. rdar://154450536
adrian-prantl
force-pushed
the
154450536
branch
from
29e2381 to
072a092
Compare
augusto2112
reviewed
Dec 6, 2025
|
|
||
| ExecutionContext exe_ctx(valobj.GetExecutionContextRef()); | ||
| if (is_imported && type.GetNumFields(&exe_ctx) == 0) | ||
| CompilerType clang_type; |
There was a problem hiding this comment.
You can move this to under the early return
| type.GetTypeSystem().dyn_cast_or_null<TypeSystemSwift>(); | ||
| if (ts && | ||
| ts->IsImportedType(type.GetOpaqueQualType(), &clang_type)) | ||
| is_imported = true; |
There was a problem hiding this comment.
if (!ts)
return false
CompilerType clang_type;
bool is_imported = ts->IsImportedType(type.GetOpaqueQualType(), &clang_type);
| g_formatters.push_back( | ||
| [](lldb_private::ValueObject &valobj, lldb::DynamicValueType dyn_type, | ||
| FormatManager &format_manager) -> lldb::SyntheticChildrenSP { | ||
| struct IsEligible { |
There was a problem hiding this comment.
I know this isn't your code, but it's hard to understand what "IsEligible" is checking for. Could you comment this function, either on top or inside it explaining what the eligibility criteria are?
Also, this structure with static function could be replaced by a lambda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by defering to the Objective-C runtime. This functionality is implemented in the visitor because ObjC object typerefs are fully valid reference types in the Swift reflection descriptors already and only LLDB wants to look inside them.
rdar://154450536