Tidying up tests

- Added getDefaultEventLoopGroup() which will return TS or non TS EventLoopGroup based on environment variable ENABLE_TS_TESTS being set.
- Added clientGroup and serverGroup EventLoopGroups to HTTPClientTests.
- Stopped using TLS in Redirection tests as it is unnecessary and is hiding if TS version of code is working

Author: adam-fowler

Tests/AsyncHTTPClientTests/HTTPClientInternalTests.swift

@@ -356,7 +356,7 @@ class HTTPClientInternalTests: XCTestCase {
             }
         }
 
-        let group = MultiThreadedEventLoopGroup(numberOfThreads: 3)
+        let group = getDefaultEventLoopGroup(numberOfThreads: 3)
         defer {
             XCTAssertNoThrow(try group.syncShutdownGracefully())
         }
@@ -549,7 +549,11 @@ class HTTPClientInternalTests: XCTestCase {
         }
 
         let url = "http://127.0.0.1:\(server.localAddress!.port!)"
-        let client = HTTPClient(eventLoopGroupProvider: .shared(group))
+        let elg = getDefaultEventLoopGroup(numberOfThreads: 1)
+        defer {
+            XCTAssertNoThrow(try elg.syncShutdownGracefully())
+        }
+        let client = HTTPClient(eventLoopGroupProvider: .shared(elg))
         defer {
             XCTAssertNoThrow(try client.syncShutdown())
         }

Tests/AsyncHTTPClientTests/HTTPClientTestUtils.swift

@@ -19,6 +19,17 @@ import NIOConcurrencyHelpers
 import NIOHTTP1
 import NIOHTTPCompression
 import NIOSSL
+import NIOTransportServices
+
+func getDefaultEventLoopGroup(numberOfThreads: Int) -> EventLoopGroup {
+    #if canImport(Network)
+    if #available(OSX 10.14, iOS 12.0, tvOS 12.0, watchOS 6.0, *),
+    ProcessInfo.processInfo.environment["ENABLE_TS_TESTS"] != nil {
+        return NIOTSEventLoopGroup(loopCount: numberOfThreads, defaultQoS: .default)
+    }
+    #endif
+    return MultiThreadedEventLoopGroup(numberOfThreads: numberOfThreads)
+}
 
 class TestHTTPDelegate: HTTPClientResponseDelegate {
     typealias Response = Void