fix: silence autofocus a11y warning inside <dialog> (#16341)

navorite · web-flow · commit 96c1a1004247 · 2025-07-11T10:41:59.000-07:00
diff --git a/.changeset/cuddly-humans-end.md b/.changeset/cuddly-humans-end.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: silence autofocus a11y warning inside `<dialog>`
diff --git a/packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y.js b/packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y.js
@@ -877,7 +877,7 @@ export function check_element(node, context) {
 		}
 
 		// no-autofocus
-		if (name === 'autofocus') {
+		if (name === 'autofocus' && node.name !== 'dialog' && !is_parent(context.path, ['dialog'])) {
 			w.a11y_autofocus(attribute);
 		}
 
diff --git a/packages/svelte/tests/validator/samples/a11y-no-autofocus/input.svelte b/packages/svelte/tests/validator/samples/a11y-no-autofocus/input.svelte
@@ -1 +1,6 @@
-<div autofocus></div>
+<div autofocus></div>
+<dialog autofocus>
+</dialog>
+<dialog>
+	<input autofocus>
+</dialog>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: silence autofocus a11y warning inside `<dialog>`
Original file line number	Diff line number	Diff line change
`@@ -877,7 +877,7 @@ export function check_element(node, context) {`
`877`	`877`	`}`
`878`	`878`
`879`	`879`	`// no-autofocus`
`880`		`- if (name === 'autofocus') {`
	`880`	`+ if (name === 'autofocus' && node.name !== 'dialog' && !is_parent(context.path, ['dialog'])) {`
`881`	`881`	`w.a11y_autofocus(attribute);`
`882`	`882`	`}`
`883`	`883`