Skip to content

Conversation

@hmnd
Copy link
Contributor

@hmnd hmnd commented Nov 27, 2025

fixes #11746

Delightfully simple to add this as a feature!

Couple things I'm not sure of:

  • The server-side match includes endpoints. Is it more confusing to include them or is it better to exclude to maintain parity with client?
  • generate:types doesn't add match to index.d.ts for some reason. How do I can I get it to work?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2025

🦋 Changeset detected

Latest commit: 9e9ab44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@PatrickG
Copy link
Member

PatrickG commented Nov 29, 2025

IMO this would also need to call the reroute hook.
Also, we should not duplicate this logic, on the client we could use get_navigation_intent. Something like this:

/**
 * @param {string | URL} url
 */
export async function match(url) {
  if (typeof url === 'string') {
    url = new URL(url, location.href);
  }

  const intent = await get_navigation_intent(url);
  if (intent) {
    return {
      id: intent.id,
      params: intent.params
    };
  }
}

On the server this might be a bit more tricky since this logic is scattered over almost 100 lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a function to map from path to routeId (inverse of resolveRoute fn)

2 participants