Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Commit ad297a4

Browse files
committed
added todo ticket number, cleanup
1 parent 33b1715 commit ad297a4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/dataunion/DataUnion.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ export class DataUnion {
388388
const members = memberAddressList.map(getAddress) // throws if there are bad addresses
389389
const duSidechain = await this.getContracts().getSidechainContract(this.contractAddress)
390390
const tx = await duSidechain.addMembers(members)
391-
// TODO: wrap promise for better error reporting in case tx fails (parse reason, throw proper error)
391+
// TODO ETH-93: wrap promise for better error reporting in case tx fails (parse reason, throw proper error)
392392
return tx.wait()
393393
}
394394

@@ -401,7 +401,7 @@ export class DataUnion {
401401
const members = memberAddressList.map(getAddress) // throws if there are bad addresses
402402
const duSidechain = await this.getContracts().getSidechainContract(this.contractAddress)
403403
const tx = await duSidechain.partMembers(members)
404-
// TODO: wrap promise for better error reporting in case tx fails (parse reason, throw proper error)
404+
// TODO ETH-93: wrap promise for better error reporting in case tx fails (parse reason, throw proper error)
405405
return tx.wait()
406406
}
407407

@@ -499,7 +499,6 @@ export class DataUnion {
499499
* @internal
500500
*/
501501
static async _deploy(options: DataUnionDeployOptions = {}, client: StreamrClient): Promise<DataUnion> {
502-
const deployerAddress = await client.getAddress()
503502
const {
504503
owner,
505504
joinPartAgents,
@@ -510,6 +509,7 @@ export class DataUnion {
510509
confirmations = 1,
511510
gasPrice
512511
} = options
512+
const deployerAddress = await client.getAddress()
513513

514514
let duName = dataUnionName
515515
if (!duName) {

0 commit comments

Comments
 (0)