From e5cb5c719877045c9f0bb5b4f883d4c800f971b1 Mon Sep 17 00:00:00 2001 From: Zadkiel AHARONIAN Date: Tue, 28 Oct 2025 19:46:33 +0100 Subject: [PATCH 1/2] fix: Add test for resource name pattern matching --- application/tests/common_test.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/application/tests/common_test.yaml b/application/tests/common_test.yaml index 3ea27da3..6da94c66 100644 --- a/application/tests/common_test.yaml +++ b/application/tests/common_test.yaml @@ -52,6 +52,14 @@ x-keys: skipEmptyTemplates: true tests: + - it: Resource names + documentSelector: + <<: *x-documentSelector + asserts: + - matchRegex: + path: metadata.name + pattern: ^RELEASE-NAME(?:-.+)?$ + - it: Default common labels documentSelector: <<: *x-documentSelector From 72ca52f0aa130c020661d34999c98150794eaec9 Mon Sep 17 00:00:00 2001 From: Zadkiel AHARONIAN Date: Tue, 28 Oct 2025 19:51:44 +0100 Subject: [PATCH 2/2] Add tests for valid resource name rendering --- application/tests/common_test.yaml | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/application/tests/common_test.yaml b/application/tests/common_test.yaml index 6da94c66..a8be89e8 100644 --- a/application/tests/common_test.yaml +++ b/application/tests/common_test.yaml @@ -52,14 +52,34 @@ x-keys: skipEmptyTemplates: true tests: - - it: Resource names - documentSelector: - <<: *x-documentSelector + - it: should render valid resource names using default release name + set: + applicationName: "" asserts: - matchRegex: path: metadata.name pattern: ^RELEASE-NAME(?:-.+)?$ + - it: should render valid resource names using actual release name + set: + applicationName: "" + release: + name: myapp + asserts: + - matchRegex: + path: metadata.name + pattern: ^myapp(?:-.+)?$ + + - it: should render valid resource names when applicationName is set + set: + applicationName: myapp + release: + name: whatever + asserts: + - matchRegex: + path: metadata.name + pattern: ^myapp(?:-.+)?$ + - it: Default common labels documentSelector: <<: *x-documentSelector