Skip to content

Commit a2f30cc

Browse files
authored
Extend unit tests of updates using CIDRSliceFlag (#175)
1 parent afd19ba commit a2f30cc

File tree

6 files changed

+66
-0
lines changed

6 files changed

+66
-0
lines changed

internal/cmd/mariadb/instance/update/update_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,17 @@ func TestParseInput(t *testing.T) {
226226
flagValues: fixtureFlagValues(),
227227
isValid: false,
228228
},
229+
{
230+
description: "no acl flag",
231+
argValues: fixtureArgValues(),
232+
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
233+
delete(flagValues, sgwAclFlag)
234+
}),
235+
isValid: true,
236+
expectedModel: fixtureInputModel(func(model *inputModel) {
237+
model.SgwAcl = nil
238+
}),
239+
},
229240
{
230241
description: "repeated acl flags",
231242
argValues: fixtureArgValues(),

internal/cmd/mongodbflex/instance/update/update_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,17 @@ func TestParseInput(t *testing.T) {
251251
}),
252252
isValid: false,
253253
},
254+
{
255+
description: "no acl flag",
256+
argValues: fixtureArgValues(),
257+
flagValues: fixtureStandardFlagValues(func(flagValues map[string]string) {
258+
delete(flagValues, aclFlag)
259+
}),
260+
isValid: true,
261+
expectedModel: fixtureStandardInputModel(func(model *inputModel) {
262+
model.ACL = nil
263+
}),
264+
},
254265
{
255266
description: "repeated acl flags",
256267
argValues: fixtureArgValues(),

internal/cmd/opensearch/instance/update/update_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,17 @@ func TestParseInput(t *testing.T) {
226226
flagValues: fixtureFlagValues(),
227227
isValid: false,
228228
},
229+
{
230+
description: "no acl flag",
231+
argValues: fixtureArgValues(),
232+
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
233+
delete(flagValues, sgwAclFlag)
234+
}),
235+
isValid: true,
236+
expectedModel: fixtureInputModel(func(model *inputModel) {
237+
model.SgwAcl = nil
238+
}),
239+
},
229240
{
230241
description: "repeated acl flags",
231242
argValues: fixtureArgValues(),

internal/cmd/postgresflex/instance/update/update_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,17 @@ func TestParseInput(t *testing.T) {
251251
}),
252252
isValid: false,
253253
},
254+
{
255+
description: "no acl flag",
256+
argValues: fixtureArgValues(),
257+
flagValues: fixtureStandardFlagValues(func(flagValues map[string]string) {
258+
delete(flagValues, aclFlag)
259+
}),
260+
isValid: true,
261+
expectedModel: fixtureStandardInputModel(func(model *inputModel) {
262+
model.ACL = nil
263+
}),
264+
},
254265
{
255266
description: "repeated acl flags",
256267
argValues: fixtureArgValues(),

internal/cmd/rabbitmq/instance/update/update_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,17 @@ func TestParseInput(t *testing.T) {
226226
flagValues: fixtureFlagValues(),
227227
isValid: false,
228228
},
229+
{
230+
description: "no acl flag",
231+
argValues: fixtureArgValues(),
232+
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
233+
delete(flagValues, sgwAclFlag)
234+
}),
235+
isValid: true,
236+
expectedModel: fixtureInputModel(func(model *inputModel) {
237+
model.SgwAcl = nil
238+
}),
239+
},
229240
{
230241
description: "repeated acl flags",
231242
argValues: fixtureArgValues(),

internal/cmd/redis/instance/update/update_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,17 @@ func TestParseInput(t *testing.T) {
226226
flagValues: fixtureFlagValues(),
227227
isValid: false,
228228
},
229+
{
230+
description: "no acl flag",
231+
argValues: fixtureArgValues(),
232+
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
233+
delete(flagValues, sgwAclFlag)
234+
}),
235+
isValid: true,
236+
expectedModel: fixtureInputModel(func(model *inputModel) {
237+
model.SgwAcl = nil
238+
}),
239+
},
229240
{
230241
description: "repeated acl flags",
231242
argValues: fixtureArgValues(),

0 commit comments

Comments
 (0)