Rename readScopedIdent to readIdentList

Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>

Author: agarciamontoro

sql/parse/util.go

@@ -262,14 +262,14 @@ func readIdent(ident *string) parseFunc {
 	}
 }
 
-// Reads a scoped identifier, populating the specified slice with the different
-// parts of the identifier if it is correctly formed.
+// readIdentList reads a scoped identifier, populating the specified slice
+// with the different parts of the identifier if it is correctly formed.
 // A scoped identifier is a sequence of identifiers separated by the specified
 // rune in separator. An identifier is a string of runes whose first character
 // is a letter and the following ones are either letters, digits or underscores.
 // An example of a correctly formed scoped identifier is "dbName.tableName",
 // that would populate the slice with the values ["dbName", "tableName"]
-func readScopedIdent(separator rune, idents *[]string) parseFunc {
+func readIdentList(separator rune, idents *[]string) parseFunc {
 	return func(r *bufio.Reader) error {
 		var buf bytes.Buffer
 		if err := readLetter(r, &buf); err != nil {

sql/parse/util_test.go

@@ -150,9 +150,9 @@ func TestReadValidScopedIdentRune(t *testing.T) {
 	}
 }
 
-// Tests that readScopedIdent reads a list of identifiers separated by a user-
+// Tests that readIdentList reads a list of identifiers separated by a user-
 // specified rune, populating the passed slice with the identifiers found.
-func TestReadScopedIdent(t *testing.T) {
+func TestReadIdentList(t *testing.T) {
 	require := require.New(t)
 
 	testFixtures := []struct {
@@ -203,7 +203,7 @@ func TestReadScopedIdent(t *testing.T) {
 		reader := bufio.NewReader(strings.NewReader(fixture.string))
 		var actualIdents []string
 
-		err := readScopedIdent(fixture.separator, &actualIdents)(reader)
+		err := readIdentList(fixture.separator, &actualIdents)(reader)
 		require.NoError(err)
 
 		remaining, _ := reader.ReadString('\n')

sql/parse/views.go

@@ -35,7 +35,7 @@ func parseCreateView(ctx *sql.Context, s string) (sql.Node, error) {
 		skipSpaces,
 		expect("view"),
 		skipSpaces,
-		readScopedIdent('.', &scopedName),
+		readIdentList('.', &scopedName),
 		skipSpaces,
 		maybeList('(', ',', ')', &columns),
 		skipSpaces,