Linting and minor package updates

Author: gionatamettifogo

.eslintrc.js

@@ -4,15 +4,15 @@ module.exports = {
   plugins: ['@typescript-eslint', 'node', 'prettier'],
   parserOptions: {
     tsconfigRootDir: __dirname,
-    project: ['./tsconfig.json'],
+    project: ['./tsconfig.json']
   },
   extends: [
     'eslint:recommended',
     'plugin:node/recommended',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
     'plugin:@typescript-eslint/recommended-requiring-type-checking',
-    'plugin:prettier/recommended',
+    'plugin:prettier/recommended'
   ],
   rules: {
     'prettier/prettier': 'warn',
@@ -23,11 +23,12 @@ module.exports = {
     'node/shebang': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     quotes: ['warn', 'single', { avoidEscape: true }],
-    'semi': ['error', 'never'],
+    semi: ['error', 'never'],
     'node/no-unpublished-import': 'off',
     '@typescript-eslint/no-unsafe-assignment': 'off',
     '@typescript-eslint/no-var-requires': 'off',
     '@typescript-eslint/ban-ts-comment': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
-  },
-};
+    '@typescript-eslint/no-unsafe-member-access': 'off'
+  }
+}

package-lock.json

@@ -48,15 +48,15 @@
   },
   "devDependencies": {
     "@types/jest": "^29.5.11",
-    "@types/lz4": "^0.6.3",
+    "@types/lz4": "^0.6.4",
     "@types/node": "^12.20.55",
     "@typescript-eslint/eslint-plugin": "^4.22.0",
     "@typescript-eslint/parser": "^4.22.0",
-    "dotenv": "^16.3.1",
-    "eslint": "^7.25.0",
-    "eslint-config-prettier": "^8.3.0",
+    "dotenv": "^16.4.1",
+    "eslint": "^7.32.0",
+    "eslint-config-prettier": "^8.10.0",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^3.4.0",
+    "eslint-plugin-prettier": "^3.4.1",
     "jest": "^29.7.0",
     "prettier": "^2.2.1",
     "sqlite3": "^5.1.6",

package.json

@@ -3,7 +3,7 @@
  */
 
 import { SQLiteCloudConfig, SQLiteCloudError, ErrorCallback, ResultsCallback } from './types'
-import { parseConnectionString, parseBoolean, isBrowser, isNode } from './utilities'
+import { parseConnectionString, parseBoolean, isBrowser } from './utilities'
 
 /** Default timeout value for queries */
 export const DEFAULT_TIMEOUT = 300 * 1000
@@ -116,11 +116,13 @@ export class SQLiteCloudConnection {
     config.sqliteMode = parseBoolean(config.sqliteMode)
 
     if (!config.username || !config.password || !config.host) {
-      console.error(`SQLiteCloudConnection.validateConfiguration - missing arguments`, config)
+      console.error('SQLiteCloudConnection.validateConfiguration - missing arguments', config)
       throw new SQLiteCloudError('The user, password and host arguments must be specified.', { errorCode: 'ERR_MISSING_ARGS' })
     }
 
     if (!config.connectionString) {
+      // build connection string from configuration, values are already validated
+      // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
       config.connectionString = `sqlitecloud://${config.username}:${config.password}@${config.host}:${config.port}/${config.database}`
     }
 

src/connection.ts

@@ -162,7 +162,7 @@ export class TlsSocketTransport implements ConnectionTransport {
               if (bufferString.length > 1000) {
                 bufferString = bufferString.substring(0, 100) + '...' + bufferString.substring(bufferString.length - 40)
               }
-              const elapsedMs = new Date().getTime() - startedOn.getTime()
+              // const elapsedMs = new Date().getTime() - startedOn.getTime()
               // console.debug(`Receive: ${bufferString} - ${elapsedMs}ms`)
             }
 

src/transport-tls.ts

@@ -31,8 +31,8 @@ export class WebSocketTransport implements ConnectionTransport {
       console.assert(!this.connected, 'Connection already established')
       if (!this.socket) {
         this.config = config
-        let connectionString = this.config.connectionString as string
-        let gatewayUrl = this.config?.gatewayUrl || `ws://${this.config.host}:4000`
+        const connectionString = this.config.connectionString as string
+        const gatewayUrl = this.config?.gatewayUrl || `ws://${this.config.host as string}:4000`
         this.socket = io(gatewayUrl, { auth: { token: connectionString } })
       }
       callback?.call(this, null)
@@ -59,7 +59,9 @@ export class WebSocketTransport implements ConnectionTransport {
         const { data, metadata } = response
         if (data && metadata) {
           if (metadata.numberOfRows !== undefined && metadata.numberOfColumns !== undefined && metadata.columns !== undefined) {
-            // we can recreate a SQLiteCloudRowset from the response
+            console.assert(Array.isArray(data), 'SQLiteCloudWebsocketConnection.processCommands - data is not an array')
+            // we can recreate a SQLiteCloudRowset from the response which we know to be an array of arrays
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-call
             const rowset = new SQLiteCloudRowset(metadata, data.flat())
             callback?.call(this, null, rowset)
             return