Add @Nullable to changePassword parameters in UserDetailsManager

Also, an unused argument was removed from
JdbcUserDetailsManager#createNewAuthentication that was not used and
would break the build of the current change.

Closes: gh-18257

Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>

Author: therepanic

core/src/main/java/org/springframework/security/provisioning/InMemoryUserDetailsManager.java

@@ -130,7 +130,7 @@ public boolean userExists(String username) {
 	}
 
 	@Override
-	public void changePassword(String oldPassword, String newPassword) {
+	public void changePassword(@Nullable String oldPassword, @Nullable String newPassword) {
 		Authentication currentUser = this.securityContextHolderStrategy.getContext().getAuthentication();
 		if (currentUser == null) {
 			// This would indicate bad coding somewhere

core/src/main/java/org/springframework/security/provisioning/JdbcUserDetailsManager.java

@@ -67,6 +67,7 @@
  *
  * @author Luke Taylor
  * @author Junhyeok Lee
+ * @author Andrey Litvitski
  * @since 2.0
  */
 public class JdbcUserDetailsManager extends JdbcDaoImpl
@@ -308,7 +309,8 @@ private void deleteUserAuthorities(String username) {
 	}
 
 	@Override
-	public void changePassword(String oldPassword, String newPassword) throws AuthenticationException {
+	public void changePassword(@Nullable String oldPassword, @Nullable String newPassword)
+			throws AuthenticationException {
 		Authentication currentUser = this.securityContextHolderStrategy.getContext().getAuthentication();
 		if (currentUser == null) {
 			// This would indicate bad coding somewhere
@@ -328,14 +330,14 @@ public void changePassword(String oldPassword, String newPassword) throws Authen
 		}
 		this.logger.debug("Changing password for user '" + username + "'");
 		requireJdbcTemplate().update(this.changePasswordSql, newPassword, username);
-		Authentication authentication = createNewAuthentication(currentUser, newPassword);
+		Authentication authentication = createNewAuthentication(currentUser);
 		SecurityContext context = this.securityContextHolderStrategy.createEmptyContext();
 		context.setAuthentication(authentication);
 		this.securityContextHolderStrategy.setContext(context);
 		this.userCache.removeUserFromCache(username);
 	}
 
-	protected Authentication createNewAuthentication(Authentication currentAuth, String newPassword) {
+	protected Authentication createNewAuthentication(Authentication currentAuth) {
 		UserDetails user = loadUserByUsername(currentAuth.getName());
 		UsernamePasswordAuthenticationToken newAuthentication = UsernamePasswordAuthenticationToken.authenticated(user,
 				null, user.getAuthorities());

core/src/main/java/org/springframework/security/provisioning/UserDetailsManager.java

@@ -16,6 +16,8 @@
 
 package org.springframework.security.provisioning;
 
+import org.jspecify.annotations.Nullable;
+
 import org.springframework.security.core.userdetails.UserDetails;
 import org.springframework.security.core.userdetails.UserDetailsService;
 
@@ -49,7 +51,7 @@ public interface UserDetailsManager extends UserDetailsService {
 	 * @param oldPassword current password (for re-authentication if required)
 	 * @param newPassword the password to change to
 	 */
-	void changePassword(String oldPassword, String newPassword);
+	void changePassword(@Nullable String oldPassword, @Nullable String newPassword);
 
 	/**
 	 * Check if a user with the supplied login name exists in the system.