Ensure that Tomcat is completely stopped when its initialization fails

Closes gh-12736

Author: wilkinsona

spring-boot/src/main/java/org/springframework/boot/context/embedded/tomcat/TomcatEmbeddedServletContainer.java

@@ -134,6 +134,7 @@ public void lifecycleEvent(LifecycleEvent event) {
 				}
 			}
 			catch (Exception ex) {
+				stopSilently();
 				throw new EmbeddedServletContainerException(
 						"Unable to start embedded Tomcat", ex);
 			}

spring-boot/src/test/java/org/springframework/boot/context/embedded/tomcat/TomcatEmbeddedServletContainerFactoryTests.java

@@ -23,6 +23,7 @@
 import java.util.Locale;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
 
 import javax.naming.InitialContext;
 import javax.naming.NamingException;
@@ -491,7 +492,18 @@ public void sessionIdGeneratorIsConfiguredWithAttributesFromTheManager() {
 
 	@Test
 	public void faultyFilterCausesStartFailure() throws Exception {
-		AbstractEmbeddedServletContainerFactory factory = getFactory();
+		final AtomicReference<Tomcat> tomcatReference = new AtomicReference<Tomcat>();
+		TomcatEmbeddedServletContainerFactory factory = new TomcatEmbeddedServletContainerFactory(
+				0) {
+
+			@Override
+			protected TomcatEmbeddedServletContainer getTomcatEmbeddedServletContainer(
+					Tomcat tomcat) {
+				tomcatReference.set(tomcat);
+				return super.getTomcatEmbeddedServletContainer(tomcat);
+			}
+
+		};
 		factory.addInitializers(new ServletContextInitializer() {
 
 			@Override
@@ -518,7 +530,13 @@ public void destroy() {
 
 		});
 		this.thrown.expect(EmbeddedServletContainerException.class);
-		factory.getEmbeddedServletContainer().start();
+		try {
+			factory.getEmbeddedServletContainer();
+		}
+		finally {
+			assertThat(tomcatReference.get().getServer().getState())
+					.isEqualTo(LifecycleState.STOPPED);
+		}
 	}
 
 	@Override