Use String.replace() with single char if possible

dreis2211 · snicoll · commit d58f38f6f646 · 2017-01-25T11:01:52.000+01:00
See gh-8089
diff --git a/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/mvc/HealthMvcEndpoint.java b/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/endpoint/mvc/HealthMvcEndpoint.java
@@ -139,7 +139,7 @@ public Object invoke(HttpServletRequest request) {
 	private HttpStatus getStatus(Health health) {
 		String code = health.getStatus().getCode();
 		if (code != null) {
-			code = code.toLowerCase().replace("_", "-");
+			code = code.toLowerCase().replace('_', '-');
 			for (String candidate : RelaxedNames.forCamelCase(code)) {
 				HttpStatus status = this.statusMapping.get(candidate);
 				if (status != null) {
diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/cache/CacheCondition.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/cache/CacheCondition.java
@@ -50,7 +50,7 @@ public ConditionOutcome getMatchOutcome(ConditionContext context,
 		}
 		CacheType cacheType = CacheConfigurations
 				.getType(((AnnotationMetadata) metadata).getClassName());
-		String value = resolver.getProperty("type").replace("-", "_").toUpperCase();
+		String value = resolver.getProperty("type").replace('-', '_').toUpperCase();
 		if (value.equals(cacheType.name())) {
 			return ConditionOutcome.match(message.because(value + " cache type"));
 		}
diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/session/SessionCondition.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/session/SessionCondition.java
@@ -45,7 +45,7 @@ public ConditionOutcome getMatchOutcome(ConditionContext context,
 			return ConditionOutcome.noMatch(
 					message.didNotFind("spring.session.store-type property").atAll());
 		}
-		String value = resolver.getProperty("store-type").replace("-", "_").toUpperCase();
+		String value = resolver.getProperty("store-type").replace('-', '_').toUpperCase();
 		if (value.equals(sessionStoreType.name())) {
 			return ConditionOutcome.match(message
 					.found("spring.session.store-type property").items(sessionStoreType));
diff --git a/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/DefaultErrorViewResolverTests.java b/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/DefaultErrorViewResolverTests.java
@@ -212,7 +212,7 @@ public void setOrderShouldChangeOrder() throws Exception {
 	private void setResourceLocation(String path) {
 		String packageName = getClass().getPackage().getName();
 		this.resourceProperties.setStaticLocations(new String[] {
-				"classpath:" + packageName.replace(".", "/") + path + "/" });
+				"classpath:" + packageName.replace('.', '/') + path + "/" });
 	}
 
 	private MockHttpServletResponse render(ModelAndView modelAndView) throws Exception {
diff --git a/spring-boot-cli/src/main/java/org/springframework/boot/cli/command/archive/ArchiveCommand.java b/spring-boot-cli/src/main/java/org/springframework/boot/cli/command/archive/ArchiveCommand.java
@@ -264,7 +264,7 @@ protected final void addClass(JarWriter writer, ClassLoader classLoader,
 			if (classLoader == null) {
 				classLoader = Thread.currentThread().getContextClassLoader();
 			}
-			String name = sourceClass.replace(".", "/") + ".class";
+			String name = sourceClass.replace('.', '/') + ".class";
 			InputStream stream = classLoader.getResourceAsStream(name);
 			writer.writeEntry(this.layout.getClassesLocation() + name, stream);
 		}
diff --git a/spring-boot-cli/src/main/java/org/springframework/boot/cli/compiler/ExtendedGroovyClassLoader.java b/spring-boot-cli/src/main/java/org/springframework/boot/cli/compiler/ExtendedGroovyClassLoader.java
@@ -161,7 +161,7 @@ protected ExtendedClassCollector(InnerLoader loader, CompilationUnit unit,
 		protected Class<?> createClass(byte[] code, ClassNode classNode) {
 			Class<?> createdClass = super.createClass(code, classNode);
 			ExtendedGroovyClassLoader.this.classResources
-					.put(classNode.getName().replace(".", "/") + ".class", code);
+					.put(classNode.getName().replace('.', '/') + ".class", code);
 			return createdClass;
 		}
 
diff --git a/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/classloader/RestartClassLoaderTests.java b/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/classloader/RestartClassLoaderTests.java
@@ -52,7 +52,7 @@ public class RestartClassLoaderTests {
 	private static final String PACKAGE = RestartClassLoaderTests.class.getPackage()
 			.getName();
 
-	private static final String PACKAGE_PATH = PACKAGE.replace(".", "/");
+	private static final String PACKAGE_PATH = PACKAGE.replace('.', '/');
 
 	private static final Charset UTF_8 = Charset.forName("UTF-8");
 
diff --git a/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/settings/DevToolsSettingsTests.java b/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/settings/DevToolsSettingsTests.java
@@ -37,7 +37,7 @@ public class DevToolsSettingsTests {
 	public TemporaryFolder temporaryFolder = new TemporaryFolder();
 
 	private static final String ROOT = DevToolsSettingsTests.class.getPackage().getName()
-			.replace(".", "/") + "/";
+			.replace('.', '/') + "/";
 
 	@Test
 	public void includePatterns() throws Exception {
diff --git a/spring-boot-test-support/src/main/java/org/springframework/boot/junit/compiler/TestCompiler.java b/spring-boot-test-support/src/main/java/org/springframework/boot/junit/compiler/TestCompiler.java
@@ -99,7 +99,7 @@ protected File getFile(Class<?> type) {
 	}
 
 	public static String sourcePathFor(Class<?> type) {
-		return type.getName().replace(".", "/") + ".java";
+		return type.getName().replace('.', '/') + ".java";
 	}
 
 	protected File getSourceFolder() {
diff --git a/spring-boot-test/src/test/java/org/springframework/boot/test/testutil/AbstractConfigurationClassTests.java b/spring-boot-test/src/test/java/org/springframework/boot/test/testutil/AbstractConfigurationClassTests.java
@@ -65,7 +65,7 @@ public void allBeanMethodsArePublic() throws IOException, ClassNotFoundException
 	private Set<AnnotationMetadata> findConfigurationClasses() throws IOException {
 		Set<AnnotationMetadata> configurationClasses = new HashSet<AnnotationMetadata>();
 		Resource[] resources = this.resolver.getResources("classpath*:"
-				+ getClass().getPackage().getName().replace(".", "/") + "/**/*.class");
+				+ getClass().getPackage().getName().replace('.', '/') + "/**/*.class");
 		for (Resource resource : resources) {
 			if (!isTestClass(resource)) {
 				MetadataReader metadataReader = new SimpleMetadataReaderFactory()
diff --git a/spring-boot-tools/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/MainClassFinder.java b/spring-boot-tools/spring-boot-loader-tools/src/main/java/org/springframework/boot/loader/tools/MainClassFinder.java
@@ -262,7 +262,7 @@ static <T> T doWithMainClasses(JarFile jarFile, String classesLocation,
 	}
 
 	private static String convertToClassName(String name, String prefix) {
-		name = name.replace("/", ".");
+		name = name.replace('/', '.');
 		name = name.replace('\\', '.');
 		name = name.substring(0, name.length() - DOT_CLASS.length());
 		if (prefix != null) {
diff --git a/spring-boot-tools/spring-boot-loader-tools/src/test/java/org/springframework/boot/loader/tools/TestJarFile.java b/spring-boot-tools/spring-boot-loader-tools/src/test/java/org/springframework/boot/loader/tools/TestJarFile.java
@@ -55,7 +55,7 @@ public void addClass(String filename, Class<?> classToCopy, Long time)
 		File file = getFilePath(filename);
 		file.getParentFile().mkdirs();
 		InputStream inputStream = getClass().getResourceAsStream(
-				"/" + classToCopy.getName().replace(".", "/") + ".class");
+				"/" + classToCopy.getName().replace('.', '/') + ".class");
 		copyToFile(inputStream, file);
 		if (time != null) {
 			file.setLastModified(time);
diff --git a/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/LaunchedURLClassLoader.java b/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/LaunchedURLClassLoader.java
@@ -132,8 +132,8 @@ private void definePackage(final String className, final String packageName) {
 			AccessController.doPrivileged(new PrivilegedExceptionAction<Object>() {
 				@Override
 				public Object run() throws ClassNotFoundException {
-					String packageEntryName = packageName.replace(".", "/") + "/";
-					String classEntryName = className.replace(".", "/") + ".class";
+					String packageEntryName = packageName.replace('.', '/') + "/";
+					String classEntryName = className.replace('.', '/') + ".class";
 					for (URL url : getURLs()) {
 						try {
 							URLConnection connection = url.openConnection();
diff --git a/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/PropertiesLauncher.java b/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/PropertiesLauncher.java
@@ -359,7 +359,7 @@ private String getProperty(String propertyKey) throws Exception {
 
 	private String getProperty(String propertyKey, String manifestKey) throws Exception {
 		if (manifestKey == null) {
-			manifestKey = propertyKey.replace(".", "-");
+			manifestKey = propertyKey.replace('.', '-');
 			manifestKey = toCamelCase(manifestKey);
 		}
 		String property = SystemPropertyUtils.getProperty(propertyKey);
diff --git a/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/util/SystemPropertyUtils.java b/spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/util/SystemPropertyUtils.java
@@ -184,11 +184,11 @@ public static String getProperty(String key, String defaultValue, String text) {
 			}
 			if (propVal == null) {
 				// Try with underscores.
-				propVal = System.getenv(key.replace(".", "_"));
+				propVal = System.getenv(key.replace('.', '_'));
 			}
 			if (propVal == null) {
 				// Try uppercase with underscores as well.
-				propVal = System.getenv(key.toUpperCase().replace(".", "_"));
+				propVal = System.getenv(key.toUpperCase().replace('.', '_'));
 			}
 			if (propVal != null) {
 				return propVal;
diff --git a/spring-boot/src/main/java/org/springframework/boot/bind/RelaxedConversionService.java b/spring-boot/src/main/java/org/springframework/boot/bind/RelaxedConversionService.java
@@ -127,7 +127,7 @@ public T convert(String source) {
 				source = source.trim();
 				for (T candidate : (Set<T>) EnumSet.allOf(this.enumType)) {
 					RelaxedNames names = new RelaxedNames(
-							candidate.name().replace("_", "-").toLowerCase());
+							candidate.name().replace('_', '-').toLowerCase());
 					for (String name : names) {
 						if (name.equals(source)) {
 							return candidate;
diff --git a/spring-boot/src/main/java/org/springframework/boot/bind/RelaxedNames.java b/spring-boot/src/main/java/org/springframework/boot/bind/RelaxedNames.java
@@ -127,7 +127,7 @@ public String apply(String value) {
 
 			@Override
 			public String apply(String value) {
-				return value.indexOf('-') != -1 ? value.replace("-", "_") : value;
+				return value.indexOf('-') != -1 ? value.replace('-', '_') : value;
 			}
 
 		},
@@ -136,7 +136,7 @@ public String apply(String value) {
 
 			@Override
 			public String apply(String value) {
-				return value.indexOf('_') != -1 ? value.replace("_", ".") : value;
+				return value.indexOf('_') != -1 ? value.replace('_', '.') : value;
 			}
 
 		},
@@ -145,7 +145,7 @@ public String apply(String value) {
 
 			@Override
 			public String apply(String value) {
-				return value.indexOf('.') != -1 ? value.replace(".", "_") : value;
+				return value.indexOf('.') != -1 ? value.replace('.', '_') : value;
 			}
 
 		},
diff --git a/spring-boot/src/main/java/org/springframework/boot/logging/AbstractLoggingSystem.java b/spring-boot/src/main/java/org/springframework/boot/logging/AbstractLoggingSystem.java
@@ -172,7 +172,7 @@ protected final ClassLoader getClassLoader() {
 
 	protected final String getPackagedConfigFile(String fileName) {
 		String defaultPath = ClassUtils.getPackageName(getClass());
-		defaultPath = defaultPath.replace(".", "/");
+		defaultPath = defaultPath.replace('.', '/');
 		defaultPath = defaultPath + "/" + fileName;
 		defaultPath = "classpath:" + defaultPath;
 		return defaultPath;
diff --git a/spring-boot/src/test/java/org/springframework/boot/context/embedded/XmlEmbeddedWebApplicationContextTests.java b/spring-boot/src/test/java/org/springframework/boot/context/embedded/XmlEmbeddedWebApplicationContextTests.java
@@ -32,7 +32,7 @@
 public class XmlEmbeddedWebApplicationContextTests {
 
 	private static final String PATH = XmlEmbeddedWebApplicationContextTests.class
-			.getPackage().getName().replace(".", "/") + "/";
+			.getPackage().getName().replace('.', '/') + "/";
 
 	private static final String FILE = "exampleEmbeddedWebApplicationConfiguration.xml";
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public ConditionOutcome getMatchOutcome(ConditionContext context,`
`50`	`50`	`}`
`51`	`51`	`CacheType cacheType = CacheConfigurations`
`52`	`52`	`.getType(((AnnotationMetadata) metadata).getClassName());`
`53`		`- String value = resolver.getProperty("type").replace("-", "_").toUpperCase();`
	`53`	`+ String value = resolver.getProperty("type").replace('-', '_').toUpperCase();`
`54`	`54`	`if (value.equals(cacheType.name())) {`
`55`	`55`	`return ConditionOutcome.match(message.because(value + " cache type"));`
`56`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public ConditionOutcome getMatchOutcome(ConditionContext context,`
`45`	`45`	`return ConditionOutcome.noMatch(`
`46`	`46`	`message.didNotFind("spring.session.store-type property").atAll());`
`47`	`47`	`}`
`48`		`- String value = resolver.getProperty("store-type").replace("-", "_").toUpperCase();`
	`48`	`+ String value = resolver.getProperty("store-type").replace('-', '_').toUpperCase();`
`49`	`49`	`if (value.equals(sessionStoreType.name())) {`
`50`	`50`	`return ConditionOutcome.match(message`
`51`	`51`	`.found("spring.session.store-type property").items(sessionStoreType));`
Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ public void setOrderShouldChangeOrder() throws Exception {`
`212`	`212`	`private void setResourceLocation(String path) {`
`213`	`213`	`String packageName = getClass().getPackage().getName();`
`214`	`214`	`this.resourceProperties.setStaticLocations(new String[] {`
`215`		`- "classpath:" + packageName.replace(".", "/") + path + "/" });`
	`215`	`+ "classpath:" + packageName.replace('.', '/') + path + "/" });`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`private MockHttpServletResponse render(ModelAndView modelAndView) throws Exception {`
Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,7 @@ protected final void addClass(JarWriter writer, ClassLoader classLoader,`
`264`	`264`	`if (classLoader == null) {`
`265`	`265`	`classLoader = Thread.currentThread().getContextClassLoader();`
`266`	`266`	`}`
`267`		`- String name = sourceClass.replace(".", "/") + ".class";`
	`267`	`+ String name = sourceClass.replace('.', '/') + ".class";`
`268`	`268`	`InputStream stream = classLoader.getResourceAsStream(name);`
`269`	`269`	`writer.writeEntry(this.layout.getClassesLocation() + name, stream);`
`270`	`270`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ protected ExtendedClassCollector(InnerLoader loader, CompilationUnit unit,`
`161`	`161`	`protected Class<?> createClass(byte[] code, ClassNode classNode) {`
`162`	`162`	`Class<?> createdClass = super.createClass(code, classNode);`
`163`	`163`	`ExtendedGroovyClassLoader.this.classResources`
`164`		`- .put(classNode.getName().replace(".", "/") + ".class", code);`
	`164`	`+ .put(classNode.getName().replace('.', '/') + ".class", code);`
`165`	`165`	`return createdClass;`
`166`	`166`	`}`
`167`	`167`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ protected File getFile(Class<?> type) {`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`public static String sourcePathFor(Class<?> type) {`
`102`		`- return type.getName().replace(".", "/") + ".java";`
	`102`	`+ return type.getName().replace('.', '/') + ".java";`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`protected File getSourceFolder() {`