Fix problem reported by Checkstyle

wilkinsona · wilkinsona · commit a05a5b3f1ca5 · 2016-01-21T17:48:18.000Z
diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/gradle/FullyExecutableJarTests.java b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/gradle/FullyExecutableJarTests.java
@@ -166,11 +166,12 @@ private boolean containsLine(String toMatch, File file) throws IOException {
 
 	private List<String> readLines(File file) throws IOException {
 		BufferedReader reader = new BufferedReader(new FileReader(file));
-		String line;
 		List<String> lines = new ArrayList<String>();
 		try {
-			while ((line = reader.readLine()) != null && lines.size() < 50) {
+			String line = reader.readLine();
+			while (line != null && lines.size() < 50) {
 				lines.add(line);
+				line = reader.readLine();
 			}
 		}
 		finally {

Original file line number	Diff line number	Diff line change
`@@ -166,11 +166,12 @@ private boolean containsLine(String toMatch, File file) throws IOException {`
`166`	`166`
`167`	`167`	`private List<String> readLines(File file) throws IOException {`
`168`	`168`	`BufferedReader reader = new BufferedReader(new FileReader(file));`
`169`		`- String line;`
`170`	`169`	`List<String> lines = new ArrayList<String>();`
`171`	`170`	`try {`
`172`		`- while ((line = reader.readLine()) != null && lines.size() < 50) {`
	`171`	`+ String line = reader.readLine();`
	`172`	`+ while (line != null && lines.size() < 50) {`
`173`	`173`	`lines.add(line);`
	`174`	`+ line = reader.readLine();`
`174`	`175`	`}`
`175`	`176`	`}`
`176`	`177`	`finally {`