Skip to content

Commit 905451f

Browse files
author
Dave Syer
committed
That BaseConfiguration thing didn't work out after all
It seems like a base class that defines `@Beans` just doesn't define any beans. Oh well, time to copy-paste.
1 parent 1babdd5 commit 905451f

File tree

3 files changed

+22
-44
lines changed

3 files changed

+22
-44
lines changed

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/client/BaseConfiguration.java

Lines changed: 0 additions & 39 deletions
This file was deleted.

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2RestOperationsConfiguration.java

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import org.springframework.security.oauth2.client.token.AccessTokenRequest;
5151
import org.springframework.security.oauth2.client.token.DefaultAccessTokenRequest;
5252
import org.springframework.security.oauth2.client.token.grant.client.ClientCredentialsResourceDetails;
53+
import org.springframework.security.oauth2.client.token.grant.code.AuthorizationCodeResourceDetails;
5354
import org.springframework.security.oauth2.common.DefaultOAuth2AccessToken;
5455
import org.springframework.security.oauth2.config.annotation.web.configuration.EnableOAuth2Client;
5556
import org.springframework.security.oauth2.config.annotation.web.configuration.OAuth2ClientConfiguration;
@@ -99,7 +100,15 @@ public DefaultOAuth2ClientContext oauth2ClientContext() {
99100
@Configuration
100101
@ConditionalOnBean(OAuth2ClientConfiguration.class)
101102
@ConditionalOnWebApplication
102-
protected static class SessionScopedConfiguration extends BaseConfiguration {
103+
protected static class SessionScopedConfiguration {
104+
105+
@Bean
106+
@ConfigurationProperties("security.oauth2.client")
107+
@Primary
108+
public AuthorizationCodeResourceDetails oauth2RemoteResource() {
109+
AuthorizationCodeResourceDetails details = new AuthorizationCodeResourceDetails();
110+
return details;
111+
}
103112

104113
@Bean
105114
public FilterRegistrationBean oauth2ClientFilterRegistration(
@@ -136,7 +145,15 @@ public DefaultOAuth2ClientContext oauth2ClientContext() {
136145
@Configuration
137146
@ConditionalOnMissingBean(OAuth2ClientConfiguration.class)
138147
@ConditionalOnWebApplication
139-
protected static class RequestScopedConfiguration extends BaseConfiguration {
148+
protected static class RequestScopedConfiguration {
149+
150+
@Bean
151+
@ConfigurationProperties("security.oauth2.client")
152+
@Primary
153+
public AuthorizationCodeResourceDetails oauth2RemoteResource() {
154+
AuthorizationCodeResourceDetails details = new AuthorizationCodeResourceDetails();
155+
return details;
156+
}
140157

141158
@Bean
142159
@Scope(value = "request", proxyMode = ScopedProxyMode.INTERFACES)

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/oauth2/sso/BasicOAuth2SsoConfigurationTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@
4949
@RunWith(SpringJUnit4ClassRunner.class)
5050
@SpringApplicationConfiguration(TestConfiguration.class)
5151
@WebAppConfiguration
52-
@TestPropertySource(properties = { "security.oauth2.client.clientId=client",
52+
@TestPropertySource(properties = { "debug=true", "security.oauth2.client.clientId=client",
5353
"security.oauth2.client.clientSecret=secret",
54-
"security.oauth2.client.authorizationUri=http://example.com/oauth/authorize",
55-
"security.oauth2.client.tokenUri=http://example.com/oauth/token",
54+
"security.oauth2.client.userAuthorizationUri=http://example.com/oauth/authorize",
55+
"security.oauth2.client.accessTokenUri=http://example.com/oauth/token",
5656
"security.oauth2.resource.jwt.keyValue=SSSSHHH" })
5757
public class BasicOAuth2SsoConfigurationTests {
5858

0 commit comments

Comments
 (0)