Fix handling of spaces in container's document root

See gh-10706

Author: alibk0rd

spring-boot/src/main/java/org/springframework/boot/context/embedded/AbstractEmbeddedServletContainerFactory.java

@@ -19,6 +19,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.net.JarURLConnection;
+import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLClassLoader;
 import java.net.URLConnection;
@@ -87,7 +88,7 @@ else if (this.logger.isDebugEnabled()) {
 	}
 
 	private File getExplodedWarFileDocumentRoot() {
-		return getExplodedWarFileDocumentRoot(getCodeSourceArchive());
+		return getExplodedWarFileDocumentRoot(getCodeSourceArchive(getCodeSource()));
 	}
 
 	protected List<URL> getUrlsOfJarsWithMetaInfResources() {
@@ -172,7 +173,7 @@ private File getWarFileDocumentRoot() {
 	}
 
 	private File getArchiveFileDocumentRoot(String extension) {
-		File file = getCodeSourceArchive();
+		File file = getCodeSourceArchive(getCodeSource());
 		if (this.logger.isDebugEnabled()) {
 			this.logger.debug("Code archive: " + file);
 		}
@@ -193,26 +194,35 @@ private File getCommonDocumentRoot() {
 		return null;
 	}
 
-	private File getCodeSourceArchive() {
+	File getCodeSourceArchive(CodeSource codeSource) {
 		try {
-			CodeSource codeSource = getClass().getProtectionDomain().getCodeSource();
 			URL location = (codeSource == null ? null : codeSource.getLocation());
 			if (location == null) {
 				return null;
 			}
-			String path = location.getPath();
+			String path;
 			URLConnection connection = location.openConnection();
 			if (connection instanceof JarURLConnection) {
 				path = ((JarURLConnection) connection).getJarFile().getName();
 			}
-			if (path.indexOf("!/") != -1) {
+			else {
+				path = location.toURI().getPath();
+			}
+			if (path.contains("!/")) {
 				path = path.substring(0, path.indexOf("!/"));
 			}
 			return new File(path);
 		}
 		catch (IOException ex) {
 			return null;
 		}
+		catch (URISyntaxException e) {
+			return null;
+		}
+	}
+
+	private CodeSource getCodeSource() {
+		return getClass().getProtectionDomain().getCodeSource();
 	}
 
 	protected final File getValidSessionStoreDir() {

spring-boot/src/test/java/org/springframework/boot/context/embedded/AbstractEmbeddedServletContainerFactoryTests.java

@@ -30,9 +30,11 @@
 import java.net.URISyntaxException;
 import java.net.URL;
 import java.nio.charset.Charset;
+import java.security.CodeSource;
 import java.security.KeyStore;
 import java.security.KeyStoreException;
 import java.security.NoSuchAlgorithmException;
+import java.security.cert.Certificate;
 import java.security.cert.CertificateException;
 import java.security.cert.X509Certificate;
 import java.util.Arrays;
@@ -673,6 +675,22 @@ public void cannotReadClassPathFiles() throws Exception {
 		assertThat(response.getStatusCode()).isEqualTo(HttpStatus.NOT_FOUND);
 	}
 
+	@Test
+	public void codeSourceArchivePath() throws Exception {
+		AbstractEmbeddedServletContainerFactory factory = getFactory();
+		final CodeSource codeSource = new CodeSource(new URL("file", "", "/some/test/path/"), (Certificate[]) null);
+		final File codeSourceArchive = factory.getCodeSourceArchive(codeSource);
+		assertThat(codeSourceArchive).isEqualTo(new File("/some/test/path/"));
+	}
+
+	@Test
+	public void codeSourceArchivePathContainingSpaces() throws Exception {
+		AbstractEmbeddedServletContainerFactory factory = getFactory();
+		final CodeSource codeSource = new CodeSource(new URL("file", "", "/test/path/with%20space/"), (Certificate[]) null);
+		final File codeSourceArchive = factory.getCodeSourceArchive(codeSource);
+		assertThat(codeSourceArchive).isEqualTo(new File("/test/path/with space/"));
+	}
+
 	protected Ssl getSsl(ClientAuth clientAuth, String keyPassword, String keyStore) {
 		return getSsl(clientAuth, keyPassword, keyStore, null, null, null);
 	}