Shrink mypy whitelist for tests.test_transforms.test_transforms_post_transforms (#14141)

Co-authored-by: daniel.eades <daniel.eades@seebyte.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Author: 3 people

pyproject.toml

@@ -251,8 +251,6 @@ module = [
     "tests.test_extensions.test_ext_inheritance_diagram",
     # tests/test_intl
     "tests.test_intl.test_intl",
-    # tests/test_transforms
-    "tests.test_transforms.test_transforms_post_transforms",
     # tests/test_util
     "tests.test_util.test_util_i18n",
     "tests.test_util.test_util_inspect",

tests/test_transforms/test_transforms_post_transforms.py

@@ -19,6 +19,9 @@
 
     from _pytest.fixtures import SubRequest
 
+    from sphinx.application import Sphinx
+    from sphinx.builders import Builder
+    from sphinx.environment import BuildEnvironment
     from sphinx.testing.util import SphinxTestApp
 
 
@@ -42,7 +45,12 @@ def test_nitpicky_warning(app: SphinxTestApp) -> None:
     freshenv=True,
 )
 def test_missing_reference(app: SphinxTestApp) -> None:
-    def missing_reference(app_, env_, node_, contnode_):
+    def missing_reference(
+        app_: Sphinx,
+        env_: BuildEnvironment,
+        node_: addnodes.pending_xref,
+        contnode_: nodes.Node,
+    ) -> nodes.inline:
         assert app_ is app
         assert env_ is app.env
         assert node_['reftarget'] == 'io.StringIO'
@@ -65,7 +73,12 @@ def missing_reference(app_, env_, node_, contnode_):
     freshenv=True,
 )
 def test_missing_reference_conditional_pending_xref(app: SphinxTestApp) -> None:
-    def missing_reference(_app, _env, _node, contnode):
+    def missing_reference(
+        _app: Sphinx,
+        _env: BuildEnvironment,
+        _node: addnodes.pending_xref,
+        contnode: nodes.Node,
+    ) -> nodes.Node:
         return contnode
 
     app.warning.truncate(0)
@@ -140,11 +153,13 @@ def translator_class(self, request: SubRequest) -> type[nodes.NodeVisitor]:
         class BaseCustomTranslatorClass(nodes.NodeVisitor):
             """Base class for a custom translator class, orthogonal to ``SphinxTranslator``."""
 
-            def __init__(self, document, *_a):
+            def __init__(
+                self, document: nodes.document, _builder: Builder | None = None
+            ) -> None:
                 super().__init__(document)
                 # ignore other arguments
 
-            def dispatch_visit(self, node):
+            def dispatch_visit(self, node: nodes.Node) -> None:
                 for node_class in node.__class__.__mro__:
                     if method := getattr(self, f'visit_{node_class.__name__}', None):
                         method(node)
@@ -153,11 +168,11 @@ def dispatch_visit(self, node):
                     logger.info('generic visit: %r', node.__class__.__name__)
                     super().dispatch_visit(node)
 
-            def unknown_visit(self, node):
+            def unknown_visit(self, node: nodes.Node) -> None:
                 logger.warning('unknown visit: %r', node.__class__.__name__)
                 raise nodes.SkipDeparture  # ignore unknown departure
 
-            def visit_document(self, node):
+            def visit_document(self, node: nodes.document) -> None:
                 raise nodes.SkipDeparture  # ignore departure
 
             def mark_node(self, node: nodes.Node) -> NoReturn: