fixup

Author: daniel.eades

pyproject.toml

@@ -231,7 +231,6 @@ module = [
     "tests.test_domains.test_domain_py_fields",
     "tests.test_domains.test_domain_py_pyfunction",
     "tests.test_domains.test_domain_py_pyobject",
-    "tests.test_domains.test_domain_rst",
     "tests.test_domains.test_domain_std",
     # tests/test_environment
     "tests.test_environment.test_environment_toctree",

tests/test_domains/test_domain_rst.py

@@ -225,7 +225,7 @@ def test_rst_directive_option_type(app: SphinxTestApp) -> None:
 
 
 @pytest.mark.sphinx('html', testroot='_blank')
-def test_rst_directive_and_directive_option(app):
+def test_rst_directive_and_directive_option(app: SphinxTestApp) -> None:
     text = '.. rst:directive:: foo\n\n   .. rst:directive:option:: bar\n'
     doctree = restructuredtext.parse(app, text)
     assert_node(

tests/test_util/test_util_inspect.py

@@ -999,7 +999,7 @@ def meth(self):
 
 def test_is_builtin_class_method() -> None:
     class MyInt(int):
-        def my_method(self):
+        def my_method(self) -> None:
             pass
 
     assert inspect.is_builtin_class_method(MyInt, 'to_bytes')

tests/test_util/test_util_nodes.py

@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 from textwrap import dedent
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, cast
 
 import pytest
 from docutils import frontend, nodes
@@ -23,7 +23,9 @@
 if TYPE_CHECKING:
     from collections.abc import Iterable
 
-    from docutils.nodes import document
+    from docutils.nodes import Element, document
+
+    from sphinx.testing.util import SphinxTestApp
 
 
 def _transform(doctree: nodes.document) -> None:
@@ -225,16 +227,18 @@ def test_make_id(app, prefix, term, expected):
 
 
 @pytest.mark.sphinx('html', testroot='root')
-def test_make_id_already_registered(app):
+def test_make_id_already_registered(app: SphinxTestApp) -> None:
     document = create_new_document()
-    document.ids['term-Sphinx'] = True  # register "term-Sphinx" manually
+    document.ids['term-Sphinx'] = cast(
+        'Element', True
+    )  # register "term-Sphinx" manually
     assert make_id(app.env, document, 'term', 'Sphinx') == 'term-0'
 
 
 @pytest.mark.sphinx('html', testroot='root')
-def test_make_id_sequential(app):
+def test_make_id_sequential(app: SphinxTestApp) -> None:
     document = create_new_document()
-    document.ids['term-0'] = True
+    document.ids['term-0'] = cast('Element', True)
     assert make_id(app.env, document, 'term') == 'term-1'
 
 
@@ -249,7 +253,7 @@ def test_make_id_sequential(app):
         ('hello <world> <sphinx>', (True, 'hello <world>', 'sphinx')),
     ],
 )
-def test_split_explicit_target(title, expected):
+def test_split_explicit_target(title: str, expected: tuple[bool, str, str]) -> None:
     assert split_explicit_title(title) == expected