Changed get_full_qualified_name() + Fixed ruff and mypy

Author: RobertoRoos

sphinxarg/ext.py

@@ -13,8 +13,6 @@
 from docutils.parsers.rst import Parser
 from docutils.parsers.rst.directives import flag, unchanged
 from docutils.statemachine import StringList
-from sphinx.ext.autodoc import mock
-from sphinx.util.docutils import SphinxDirective, new_document
 from sphinx.domains import Domain, Index, IndexEntry
 from sphinx.errors import ExtensionError
 from sphinx.ext.autodoc import mock
@@ -895,8 +893,10 @@ class ArgParseDomain(Domain):
     # option is set to True.
     temporary_index_files: list[Path] = []
 
-    def get_full_qualified_name(self, node: Element) -> str:
-        return str(node.arguments[0])
+    def get_full_qualified_name(self, node: Element) -> str | None:
+        # The use of this method is not clear - the content is made to
+        # resemble :meth:`PythonDomain.get_full_qualified_name` instead
+        return node.get('reftarget', None)
 
     def get_objects(self) -> Iterable[_ObjectDescriptionTuple]:
         yield from self.data['commands']
@@ -910,7 +910,7 @@ def resolve_xref(
         target: str,
         node: pending_xref,
         contnode: Element,
-    ) -> Element | None:
+    ) -> nodes.reference | None:
         anchor_id = target_to_anchor_id(target)
         match = [
             (docname, anchor)
@@ -1016,8 +1016,12 @@ def setup(app: Sphinx):
 
     app.add_config_value('sphinxarg_build_commands_by_group_index', False, 'html', bool)
     app.add_config_value('sphinxarg_commands_by_group_index_in_toctree', False, 'html', bool)
-    app.add_config_value('sphinxarg_commands_by_group_index_file_suffix', CommandsByGroupIndex.name, 'html', str)
-    app.add_config_value('sphinxarg_commands_by_group_index_title', CommandsByGroupIndex.localname, 'html', str)
+    app.add_config_value(
+        'sphinxarg_commands_by_group_index_file_suffix', CommandsByGroupIndex.name, 'html', str
+    )
+    app.add_config_value(
+        'sphinxarg_commands_by_group_index_title', CommandsByGroupIndex.localname, 'html', str
+    )
 
     app.connect('builder-inited', configure_ext)
     app.connect('build-finished', _delete_temporary_files)

test/test_argparse_directive.py

@@ -1,7 +1,7 @@
 import pytest
 
 
-@pytest.mark.skip(reason="Refactoring")
+@pytest.mark.skip(reason='Refactoring')
 @pytest.mark.sphinx('html', testroot='argparse-directive')
 def test_bad_index_groups(app, status, warning):
     app.build()

test/test_default_html.py

@@ -18,7 +18,6 @@
                 ('.//h1', 'blah-blah', False),
                 (".//div[@class='highlight']//span", 'usage'),
                 ('.//h2', 'Positional Arguments'),
-
                 (".//section[@id='sample-directive-opts-positional-arguments']", ''),
                 (".//section/span[@id='get_parser-positional-arguments']", ''),
                 (
@@ -27,7 +26,10 @@
                 ),
                 (".//section[@id='sample-directive-opts-named-arguments']", ''),
                 (".//section/span[@id='get_parser-named-arguments']", ''),
-                (".//section[@id='sample-directive-opts-named-arguments']/dl/dt[1]/kbd", '--foo'),
+                (
+                    ".//section[@id='sample-directive-opts-named-arguments']/dl/dt[1]/kbd",
+                    '--foo',
+                ),
                 (".//section[@id='sample-directive-opts-bar-options']", ''),
                 (".//section/span[@id='get_parser-bar-options']", ''),
                 (".//section[@id='sample-directive-opts-bar-options']/dl/dt[1]/kbd", '--bar'),
@@ -42,7 +44,10 @@
                 ('.//h2', 'Positional Arguments'),
                 (".//section[@id='sample-directive-opts-A-positional-arguments']", ''),
                 (".//section/span[@id='get_parser-positional-arguments']", ''),
-                (".//section[@id='sample-directive-opts-A-positional-arguments']/dl/dt[1]/kbd", 'baz'),
+                (
+                    ".//section[@id='sample-directive-opts-A-positional-arguments']/dl/dt[1]/kbd",
+                    'baz',
+                ),
             ],
         ),
         (