Loan Prep / Loan Prep Returns not calculating/following business rules when uploaded via the WorkBench

[grantfitzsimmons]

We have the loan officer for the wildlife collection actively dealing with Specify and we’ve run into a few issues – we were hoping to use the Workbench to bulk add/resolve loan preps since we have a required field (disposition) that is very time consuming to add from the UI. However in our testing we’ve found some issues:

Creating loanpreparation objects via the workbench – the returned/resolved fields don’t get calculated unless you specifically map to them (which is dangerous to get users to populate calculated fields) – see below where B12340 was added via the workbench:

Creating loanpreparationreturn objects via the workbench – None of the calculated fields are updated. This includes the Quantity Returned, Quantity Resolved, and the IsResolved checkbox for each loan preparation, as well as the summary calculated fields for the loans. Below is a screenshot of the workbench upload:

And as you can see prep B12345 has the loanreturnpreparation object correctly created (LrP button shows 1 with the correct information in it) but the calculated values and “is Resolved” flags are not updated:

Reported By: Dan Baker at CSIRO (Asana)

[bronwyncombs]

Nate @ OSU Mollusk has encountered this with isOnLoan behavior with records uploaded through WB

[combs-a]

Pretty sure this is a part of this? Encountered it while trying to upload loan preparations and loan return preps for Rio, went investigating on sdnhm_herps_2_8_2024_v7962, on v7.9.6.2.

You can see from this query that some of these test records (TEST2 and TEST4) should be closed/resolved.

Additionally there's a bit of weirdness with unload protect when return/resolve quantities are not done at the same time. When uploading Loans via Workbench, you can't upload Loan Return Preparations at the same time since they don't appear in the Loan Preparation relationship.

When you have a resolved/returned count that does not match a Loan Return Preparation record, it causes an unload protect--if the LRP record is missing it automatically assumes that the return is off and tries to set it back to 0. This generally makes sense, but it's annoying because it means you need to do a separate upload of LRPs. It's also annoying when you just have LRPs but quantity resolved/returned isn't filled--not as concerning, but unload protect also gets triggered there since it wants to update the record itself.